fix(transform): Use path instead of field name for PK options#739
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 43.15% 43.21% +0.05%
==========================================
Files 80 80
Lines 7886 7889 +3
==========================================
+ Hits 3403 3409 +6
+ Misses 4015 4013 -2
+ Partials 468 467 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cec4f3f to
99e2a2e
Compare
⏱️ Benchmark resultsComparing with 72c2cc0
|
Contributor
|
Could you please add a description to explain what this fixes? It's useful for reviewers and for users who might later need to understand what this change did. |
Contributor
Author
|
@hermanschaaf I've added a more detailed explanation for this change in the PR description |
Contributor
|
Nice, thanks for the detailed description @candiduslynx, makes sense 👍 |
hermanschaaf
approved these changes
Mar 29, 2023
erezrokah
approved these changes
Mar 29, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks great, thanks for adding the detailed description
yevgenypats
approved these changes
Mar 31, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Mar 31, 2023
🤖 I have created a release *beep* *boop* --- ## [1.44.1](v1.44.0...v1.44.1) (2023-03-31) ### Bug Fixes * **transform:** Use path instead of field name for PK options ([#739](#739)) ([d7649d8](d7649d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq Bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Mar 31, 2023
follow-up for #9498 as cloudquery/plugin-sdk#739 was released & merged
daniel-garcia
pushed a commit
to infobloxopen/ibcq-source-k8s
that referenced
this pull request
Feb 24, 2026
follow-up for #9498 as cloudquery/plugin-sdk#739 was released & merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using
transformers.WithPrimaryKeysoption there is an odd behavior being observed, where the unwrapped struct field also gets promoted to be PK.Consider the following example:
Currently, if
transformers.WithPrimaryKeys("ID")option was used to transform structAwe would get the following columns:id: PK, taken fromAb_id: PK, taken fromBHowever, with the current change, the following becomes possible:
transformers.WithPrimaryKeysidis PKb_idis PK"ID"truefalse"B.ID"falsetrue"ID", "B.ID"truetrue