feat: Implement TransformSchema support.#1838
Merged
Merged
Conversation
⏱️ Benchmark results
|
erezrokah
approved these changes
Jul 30, 2024
marianogappa
pushed a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [4.56.0](v4.55.0...v4.56.0) (2024-07-31) ### Features * Implement TransformSchema support. ([#1838](#1838)) ([30875d6](30875d6)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.21.2 ([#1837](#1837)) ([47bb424](47bb424)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.21.3 ([#1840](#1840)) ([d2c5c7b](d2c5c7b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed offline, Transformer plugins are going to need to explicitly provide a synchronous function to transform a schema.
Previously, I implemented a method by which this wasn't necessary, by reusing the existing transform function, but the problem is that we cannot assume that the transform function is not gonna swallow the initial message of a given table, or that it's gonna behave properly with an empty record with a schema.