fix(gcp): Fix typo and condition in the CIS GCP Policy 6.3.6#9381
Merged
Conversation
Member
|
/gen sha=e7418203668a849ea1deb579de829f569f7eeb5f plugin=gcp |
Contributor
|
I think this makes sense, but we should probably add a comment about why this differs from the policy document, otherwise we might get another PR by someone else in a few weeks changing it back :) |
Contributor
Author
Great viewpoint! I've add some comments for this changes ;) |
hermanschaaf
approved these changes
Mar 29, 2023
Contributor
|
Thanks for the fix @aruneko ! |
kodiakhq Bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
🤖 I have created a release *beep* *boop* --- ## [8.4.3](plugins-source-gcp-v8.4.2...plugins-source-gcp-v8.4.3) (2023-04-04) ### This Release has the Following Changes to Tables - Table `gcp_aiplatform_batch_prediction_jobs`: column added with name `disable_container_logging` and type `Bool` - Table `gcp_aiplatform_batch_prediction_jobs`: column order changed for `encryption_spec` - Table `gcp_bigquery_datasets`: column added with name `default_rounding_mode` and type `String` - Table `gcp_bigquery_tables`: column added with name `default_rounding_mode` and type `String` - Table `gcp_clouddeploy_releases`: column added with name `condition` and type `JSON` - Table `gcp_clouddeploy_releases`: column order changed for `target_renders` - Table `gcp_clouddeploy_rollouts`: column added with name `controller_rollout` and type `String` - Table `gcp_clouddeploy_rollouts`: column order changed for `metadata` - Table `gcp_compute_forwarding_rules`: column added with name `base_forwarding_rule` and type `String` - Table `gcp_compute_forwarding_rules`: column added with name `source_ip_ranges` and type `StringArray` - Table `gcp_kms_crypto_key_versions`: column added with name `external_destruction_failure_reason` and type `String` - Table `gcp_kms_crypto_key_versions`: column added with name `generation_failure_reason` and type `String` - Table `gcp_kms_ekm_connections`: column added with name `crypto_space_path` and type `String` - Table `gcp_kms_ekm_connections`: column added with name `key_management_mode` and type `String` - Table `gcp_kms_ekm_connections`: column order changed for `etag` - Table `gcp_livestream_channels`: column added with name `encryptions` and type `JSON` - Table `gcp_livestream_channels`: column added with name `input_config` and type `JSON` - Table `gcp_livestream_channels`: column added with name `timecode_config` and type `JSON` - Table `gcp_livestream_channels`: column order changed for `log_config` - Table `gcp_translate_glossaries`: column added with name `display_name` and type `String` - Table `gcp_translate_glossaries`: column order changed for `end_time` ### Bug Fixes * **deps:** Update github.com/cncf/xds/go digest to 32f1caf ([#9562](#9562)) ([62bd1e5](62bd1e5)) * **deps:** Update golang.org/x/exp digest to 10a5072 ([#9587](#9587)) ([31f913f](31f913f)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.44.1 ([#9520](#9520)) ([202c31b](202c31b)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.44.2 ([#9661](#9661)) ([a27dc84](a27dc84)) * **deps:** Update module github.com/mattn/go-isatty to v0.0.18 ([#9609](#9609)) ([5b2908e](5b2908e)) * **gcp:** Fix typo and condition in the CIS GCP Policy 6.3.6 ([#9381](#9381)) ([e2bd07f](e2bd07f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The title, description and remediation of CIS GCP Policy v1.2.0 Section 6.3.6 has an error. It describes 3625 trace flag should be off, but in fact it should be on. The statement is fixed in CIS for GCP v1.3.0. In my opinion, for convenience, this fix should be backported in v1.2.0.