feat: Resource list enhancements#706
Merged
Merged
Conversation
Collaborator
|
I agree that we should only support blobs at the service level |
bbernays
reviewed
May 12, 2022
bbernays
approved these changes
May 12, 2022
Collaborator
bbernays
left a comment
There was a problem hiding this comment.
LGTM other than the single comment
roneli
reviewed
May 12, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Looks great had a nit on the function as I think the functions should be small and with 1 job rather then do many jobs on the resource list, other than that the logic looks great.
This was referenced May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements cloudquery/cq-provider-aws#687 and #1390
Maybe don't use "unlimited" globbing but allow only for class-level wildcards? ie. don't allows3.bu*but onlys3.*