feat: Track db installations#652
Merged
Merged
Conversation
roneli
approved these changes
May 6, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
LGTM, would add it to analytics in a separate PR
roneli
reviewed
May 6, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
maybe write a test, we have e2e tests to a PG, that just checks we get an identifier and call it twice perhaps?
This was referenced May 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: call
executor.Identifier()to get the identifier and inject it into telemetry.First we should fix the call to
executor.Validate()though. (#653 fixes this)