Skip to content

feat: Change to rudder#650

Merged
roneli merged 6 commits into
cloudquery:mainfrom
roneli:feat/change_to_rudder
May 5, 2022
Merged

feat: Change to rudder#650
roneli merged 6 commits into
cloudquery:mainfrom
roneli:feat/change_to_rudder

Conversation

@roneli
Copy link
Copy Markdown
Contributor

@roneli roneli commented May 4, 2022

No description provided.

@roneli roneli requested review from a team and amanenk and removed request for a team May 4, 2022 17:08
@github-actions github-actions Bot added the feat label May 4, 2022
Comment thread internal/analytics/client.go Outdated
Copy link
Copy Markdown
Collaborator

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a single comment

Copy link
Copy Markdown
Collaborator

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Like the ability to test out new API keys directly from the CLI

Copy link
Copy Markdown
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit 8f3f4c1 into cloudquery:main May 5, 2022
@roneli roneli deleted the feat/change_to_rudder branch May 5, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants