Skip to content

fix: Encode json#641

Merged
roneli merged 3 commits into
cloudquery:mainfrom
roneli:fix/encode_json_console
May 3, 2022
Merged

fix: Encode json#641
roneli merged 3 commits into
cloudquery:mainfrom
roneli:fix/encode_json_console

Conversation

@roneli
Copy link
Copy Markdown
Contributor

@roneli roneli commented May 3, 2022

Closes #639

@roneli roneli requested review from a team, bbernays and erezrokah and removed request for a team May 3, 2022 13:08
@roneli roneli changed the title fix encode json fix: Encode json May 3, 2022
@github-actions github-actions Bot added the fix label May 3, 2022
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @roneli. Left a non blocking commnet

Comment thread pkg/ui/output.go
Comment thread internal/logging/logger.go Outdated
@roneli roneli merged commit 1c04e45 into cloudquery:main May 3, 2022
@roneli roneli deleted the fix/encode_json_console branch May 3, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console JSON Logging not possible

3 participants