feat: Configure to return diagnostics, upgrade SDK#594
Merged
Conversation
d1e68c6 to
431fbcc
Compare
irmatov
approved these changes
Apr 22, 2022
roneli
reviewed
Apr 23, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Added a comment, around the ConfigureProviderResoruce hack
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goes with cloudquery/cq-provider-sdk#226 and cloudquery/cq-provider-aws#755
a problem: provider.Configure calls fail withdiag.ACCESS/ERROR. Since it'sERRORit's currently reported.