fix: Add safeguard for drop provider#580
Merged
Merged
Conversation
roneli
approved these changes
Apr 13, 2022
| "last-update is the duration from current time we want to remove resources from the database. "+ | ||
| "For example 24h will remove all resources that were not update in last 24 hours. Duration is a string with optional unit suffix such as \"2h45m\" or \"7d\"") | ||
| providerRemoveStaleCmd.Flags().BoolVar(&dryRun, "dry-run", true, "") | ||
| providerDropCmd.Flags().BoolVar(&iAmSure, "i-am-sure", false, "Really drop tables for the provider") |
Contributor
There was a problem hiding this comment.
nit: --force ? --approve-drop ?
Member
Author
There was a problem hiding this comment.
...but --force implies "it's normally possible to do it without forcing, but for some reason, in this instance, we can't" which is not the case here.
bbernays
approved these changes
Apr 13, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Apr 13, 2022
* upstream/main: fix: Add safeguard for drop provider (cloudquery#580) feat: Remote config (cloudquery#568) fix: Handle panic level diags (cloudquery#579)
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.