Skip to content

fix: Replace non-supported satori/go.uuid with google/uuid#576

Merged
roneli merged 1 commit into
cloudquery:mainfrom
dronnix:fix/replace_unsupported_uuid_lib
Apr 9, 2022
Merged

fix: Replace non-supported satori/go.uuid with google/uuid#576
roneli merged 1 commit into
cloudquery:mainfrom
dronnix:fix/replace_unsupported_uuid_lib

Conversation

@dronnix
Copy link
Copy Markdown
Contributor

@dronnix dronnix commented Apr 9, 2022

Hi!

The satori/go.uuid library isn't longer supported, and contains security issues. So I've replaced this with google/uuid.

@dronnix dronnix requested review from a team and roneli and removed request for a team April 9, 2022 08:33
@github-actions github-actions Bot added the fix label Apr 9, 2022
@yevgenypats
Copy link
Copy Markdown
Contributor

Thanks @dronnix ! This looks good though not sure about the severity of this as we are not using this for anything crypto/security related but prob will be a good best practice / future-proof PR in any case. I'll let @disq review.

@yevgenypats yevgenypats requested a review from disq April 9, 2022 09:03
Copy link
Copy Markdown
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit d9170a5 into cloudquery:main Apr 9, 2022
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Apr 11, 2022
* upstream/main:
  fix: Replace non-supported satori/go.uuid with google/uuid (cloudquery#576)
  fix: Drift: Remove version constraints, always include all parents (cloudquery#575)
  fix: Include all responses in log, log invocation params (cloudquery#574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants