Skip to content

fix: Drift: Remove version constraints, always include all parents#575

Merged
disq merged 2 commits into
cloudquery:mainfrom
disq:fix/drift-remove-version-constraint-feature
Apr 7, 2022
Merged

fix: Drift: Remove version constraints, always include all parents#575
disq merged 2 commits into
cloudquery:mainfrom
disq:fix/drift-remove-version-constraint-feature

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Apr 7, 2022 •
edited
Loading

  • Version constraints are not needed since HCL is bundled with the provider now
  • Second commit fixes the issue about not being able to filter two resources down, using check_resources:

This would fail:

      check_resources = [
        // "codepipeline.pipelines:*",
        // "aws_codepipeline_pipeline_stages:*",
        "aws_codepipeline_pipeline_stage_actions:*"
	]

but this would work:

      check_resources = [
        // "codepipeline.pipelines:*",
        "aws_codepipeline_pipeline_stages:*",
        "aws_codepipeline_pipeline_stage_actions:*"
	]

(now the former also works)

disq added 2 commits April 7, 2022 18:04
@disq
fix: Drift: Remove version constraints
44be5d5 
Not needed since HCL is bundled with the provider now
@disq
fix: Drift: Always include all parents of a resource
deec659 
Otherwise resources more than one level down the topmost res can't be filtered using check_resources
@disq disq requested review from a team and roneli and removed request for a team April 7, 2022 17:10
@github-actions github-actions Bot added the fix label Apr 7, 2022
@disq disq requested a review from bbernays April 7, 2022 17:10
@github-actions github-actions Bot added fix and removed fix labels Apr 7, 2022
roneli
roneli approved these changes Apr 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, always great to see code simplified.

@disq disq merged commit b1f8263 into cloudquery:main Apr 7, 2022
@disq disq deleted the fix/drift-remove-version-constraint-feature branch April 7, 2022 18:54
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Apr 11, 2022
Merge remote-tracking branch 'upstream/main'
c25b428 
* upstream/main:
  fix: Replace non-supported satori/go.uuid with google/uuid (cloudquery#576)
  fix: Drift: Remove version constraints, always include all parents (cloudquery#575)
  fix: Include all responses in log, log invocation params (cloudquery#574)
This was referenced May 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbernays bbernays Awaiting requested review from bbernays

1 more reviewer

@roneli roneli roneli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@disq @roneli