Skip to content

fix: Include all responses in log, log invocation params#574

Merged
disq merged 5 commits into
cloudquery:mainfrom
disq:fix/all-response-in-logging
Apr 7, 2022
Merged

fix: Include all responses in log, log invocation params#574
disq merged 5 commits into
cloudquery:mainfrom
disq:fix/all-response-in-logging

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Apr 7, 2022

Fixes #571.
Implements #572.

@disq disq requested review from a team and shimonp21 and removed request for a team April 7, 2022 12:43
@github-actions github-actions Bot added the fix label Apr 7, 2022
@disq disq force-pushed the fix/all-response-in-logging branch from d74c888 to fd3c5ca Compare April 7, 2022 13:09
@disq disq requested review from bbernays and roneli April 7, 2022 13:09
@disq
Copy link
Copy Markdown
Member Author

disq commented Apr 7, 2022

3:43PM INF Invocation parameters args=[] command="cloudquery drift scan" core_version=development flag:enable-console-log=true

@github-actions github-actions Bot added fix and removed fix labels Apr 7, 2022
@disq disq changed the title fix: Include all responses in log fix: Include all responses in log, log invocation params Apr 7, 2022
@github-actions github-actions Bot added fix and removed fix labels Apr 7, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disq disq merged commit 4661582 into cloudquery:main Apr 7, 2022
@disq disq deleted the fix/all-response-in-logging branch April 7, 2022 16:47
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Apr 11, 2022
* upstream/main:
  fix: Replace non-supported satori/go.uuid with google/uuid (cloudquery#576)
  fix: Drift: Remove version constraints, always include all parents (cloudquery#575)
  fix: Include all responses in log, log invocation params (cloudquery#574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debugging: Improve Error And Warnings In Output

3 participants