Skip to content

feat: Remote config#568

Merged
bbernays merged 13 commits into
cloudquery:mainfrom
bbernays:remote-config
Apr 13, 2022
Merged

feat: Remote config#568
bbernays merged 13 commits into
cloudquery:mainfrom
bbernays:remote-config

Conversation

@bbernays
Copy link
Copy Markdown
Collaborator

@bbernays bbernays commented Apr 6, 2022 •
edited
Loading

Rather than having to colocate the config.hcl file with the cq binary, this enables Cloudquery to grab a config.hcl file from s3 (to begin with).

Following calls are all supported

go run ./main.go fetch
go run ./main.go fetch --config=./config.hcl
go run ./main.go fetch --config=s3://<BUCKET_NAME>/config.hcl

Todo:

  • Add comments
  • Clean up code
  • Add Testing
  • Documentation

@github-actions github-actions Bot added feat and removed feat labels Apr 6, 2022
@github-actions github-actions Bot added feat and removed feat labels Apr 6, 2022
@bbernays bbernays linked an issue Apr 6, 2022 that may be closed by this pull request
Store Configuration in Remote Location #564
Closed
@github-actions github-actions Bot added feat and removed feat labels Apr 11, 2022
@bbernays bbernays marked this pull request as ready for review April 11, 2022 23:18
@bbernays bbernays requested review from a team, disq and roneli and removed request for a team April 11, 2022 23:18
roneli
roneli reviewed Apr 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, won't approve yet as its not finished

Comment thread pkg/config/load_config_test.go
disq
disq reviewed Apr 12, 2022
View reviewed changes
Comment thread pkg/config/parser.go Outdated
roneli
roneli approved these changes Apr 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

Comment thread pkg/config/parser.go Outdated
@bbernays bbernays merged commit 227f398 into cloudquery:main Apr 13, 2022
@bbernays bbernays deleted the remote-config branch April 13, 2022 12:07
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Apr 13, 2022
Merge remote-tracking branch 'upstream/main'
4efcda6 
* upstream/main:
  fix: Add safeguard for drop provider (cloudquery#580)
  feat: Remote config (cloudquery#568)
  fix: Handle panic level diags (cloudquery#579)
disq added a commit to disq/cloudquery that referenced this pull request Apr 14, 2022
@disq
Revert "feat: Remote config (cloudquery#568)"
2195a40 
This reverts commit 227f398.
This was referenced May 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

+1 more reviewer

@roneli roneli roneli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Store Configuration in Remote Location

3 participants

@bbernays @disq @roneli