Skip to content

feat: Use firestore for releases#483

Merged
roneli merged 8 commits into
cloudquery:mainfrom
disq:feat/use-firestore-for-releases
Feb 10, 2022
Merged

feat: Use firestore for releases#483
roneli merged 8 commits into
cloudquery:mainfrom
disq:feat/use-firestore-for-releases

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Feb 9, 2022

This is the URL it builds

roneli and others added 4 commits February 7, 2022 17:38
while creating a new release, the tag is created but the binary hasn't compiled yet, we want to avoid this by fetching the prior release until all assets are added.
@github-actions github-actions Bot added the feat label Feb 9, 2022
@disq disq requested a review from roneli February 10, 2022 12:02
@disq disq marked this pull request as ready for review February 10, 2022 12:02
@github-actions github-actions Bot added feat and removed feat labels Feb 10, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread go.mod Outdated
@roneli roneli merged commit 63f8d34 into cloudquery:main Feb 10, 2022
@disq disq deleted the feat/use-firestore-for-releases branch February 10, 2022 13:22
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Feb 10, 2022
* upstream/main:
  docs: Update suggested deployment to helm charts (cloudquery#484)
  feat: Update SDK and show resource id on diagnostics (cloudquery#480)
  feat: Use firestore for releases (cloudquery#483)
  fix: Use URI DSNs (cloudquery#482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants