feat: Testable Migrations (core)#406
Merged
Merged
Conversation
This was referenced Jan 10, 2022
f88e85c to
85822b8
Compare
roneli
suggested changes
Jan 17, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Adding some comments, requires another pass, will do one more tomorrow.
This was referenced Jan 19, 2022
0b73708 to
878eeda
Compare
roneli
approved these changes
Jan 20, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Minor nit, lets merge this as other PRs are broke because of the change.
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Jan 20, 2022
* upstream/main: fix: Better drift tfstate error (cloudquery#430) feat: Migrations v2 (core) (cloudquery#406)
This was referenced May 10, 2022
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the new version
4proto and SDK.Old migrations are no more. 🦜
TableCreator calls are also no more 🦜 unless we're using an older provider (with proto
3) or the provider didn't define any migrations (so that migrations in a provider are kept optional even with the newer proto)Please see relevant PRs on other projects:
cloudquery/cq-provider-sdk#146
cloudquery/cq-provider-aws#401
https://github.com/cloudquery/docs/pull/75
https://github.com/cloudquery/cq-provider-template/pull/12