feat: Add Support for ECR Public Repositories#2645
Merged
Conversation
Closed
| "us-east-1": {}, | ||
| "us-west-2": {}, | ||
| }, | ||
| } |
Contributor
There was a problem hiding this comment.
Ah, I see this now. Cool cool cool. I think this is fine, ignore my previous comment.
hermanschaaf
approved these changes
Oct 12, 2022
Contributor
|
Looks good, but there's a conflict now: docs will need to be regenerated after merging main into this branch. |
disq
approved these changes
Oct 12, 2022
disq
reviewed
Oct 12, 2022
| } | ||
|
|
||
| if _, ok := data.Partitions["aws"].Services["api.ecr-public"]; ok { | ||
| panic("api.ecr-public has been added to the list and code should be updated") |
kodiakhq Bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.5.0](plugins-source-aws-v2.4.0...plugins-source-aws-v2.5.0) (2022-10-12) ### Features * Add Support for ECR Public Repositories ([#2645](#2645)) ([0e5d974](0e5d974)) * **aws:** Add Column for WAFRegional for ListResourcesForWebACL ([#2648](#2648)) ([5c7dfed](5c7dfed)) ### Bug Fixes * **deps:** Update plugin-sdk for aws to v0.13.6 ([#2717](#2717)) ([0fba29f](0fba29f)) * Fix multiplexer for AWS Organizations ([#2727](#2727)) ([21bb98e](21bb98e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a few notes:
api.ecr-publicis not in the AWS manifest file we use for determining regional availability so had to update the generation file (don't love the solution but open to changing/replacing it with something else)