feat(ci): Align table summary with migration logic (#8874)

erezrokah · web-flow · commit c0abc130ac6d · 2023-03-13T09:06:29.000Z
#### Summary This aligns our tables changes summary with https://www.cloudquery.io/docs/advanced-topics/migrations. The only changes that are considered non breaking are: 1. Changing the order of a column 2. Adding a new non PK column <!--
diff --git a/scripts/table_diff/changes/changes.go b/scripts/table_diff/changes/changes.go
@@ -129,14 +129,14 @@ func getColumnChanges(file *gitdiff.File, table string) (changes []change) {
 			if addedColumn.pk() && !deletedColumn.pk() {
 				changes = append(changes, change{
 					Text:     fmt.Sprintf("Table %s: primary key constraint added to column %s", backtickStrings(table, deletedName)...),
-					Breaking: false,
+					Breaking: true,
 				})
 			}
 
 			if !addedColumn.pk() && deletedColumn.pk() {
 				changes = append(changes, change{
 					Text:     fmt.Sprintf("Table %s: primary key constraint removed from column %s", backtickStrings(table, deletedName)...),
-					Breaking: false,
+					Breaking: true,
 				})
 			}
 
