chore(scripts): Fix wording (#7349)

candiduslynx · web-flow · commit 9ca2392edec5 · 2023-01-30T15:55:19.000Z
diff --git a/scripts/table_diff/changes/changes.go b/scripts/table_diff/changes/changes.go
@@ -155,7 +155,7 @@ func getColumnChanges(file *gitdiff.File, table string) (changes []change) {
 			}
 		} else {
 			changes = append(changes, change{
-				Text:     fmt.Sprintf("Table %s: column removed %s from table", backtickStrings(table, deletedName)...),
+				Text:     fmt.Sprintf("Table %s: column %s removed from table", backtickStrings(table, deletedName)...),
 				Breaking: true,
 			})
 		}
diff --git a/scripts/table_diff/changes/changes_test.go b/scripts/table_diff/changes/changes_test.go
@@ -85,7 +85,7 @@ func Test_getChanges(t *testing.T) {
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_appservice_functions`: column removed `web_app_id` from table",
+					Text:     "Table `azure_appservice_functions`: column `web_app_id` removed from table",
 					Breaking: true,
 				},
 				{
@@ -141,35 +141,35 @@ func Test_getChanges(t *testing.T) {
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_subscription_tenants`: column removed `name` from table",
+					Text:     "Table `azure_subscription_tenants`: column `name` removed from table",
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_subscription_tenants`: column removed `properties_notes` from table",
+					Text:     "Table `azure_subscription_tenants`: column `properties_notes` removed from table",
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_subscription_tenants`: column removed `properties_source_id` from table",
+					Text:     "Table `azure_subscription_tenants`: column `properties_source_id` removed from table",
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_subscription_tenants`: column removed `properties_target_id` from table",
+					Text:     "Table `azure_subscription_tenants`: column `properties_target_id` removed from table",
 					Breaking: true,
 				},
 				{
 					Text:     "Table `azure_subscription_tenants`: column added with name `tenant_id` and type `String`",
 					Breaking: false,
 				},
 				{
-					Text:     "Table `azure_subscriptions`: column removed `managed_by_tenants` from table",
+					Text:     "Table `azure_subscriptions`: column `managed_by_tenants` removed from table",
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_subscriptions`: column removed `tags` from table",
+					Text:     "Table `azure_subscriptions`: column `tags` removed from table",
 					Breaking: true,
 				},
 				{
-					Text:     "Table `azure_subscriptions`: column removed `tenant_id` from table",
+					Text:     "Table `azure_subscriptions`: column `tenant_id` removed from table",
 					Breaking: true,
 				},
 				{

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ func getColumnChanges(file *gitdiff.File, table string) (changes []change) {`
`155`	`155`	`}`
`156`	`156`	`} else {`
`157`	`157`	`changes = append(changes, change{`
`158`		`- Text: fmt.Sprintf("Table %s: column removed %s from table", backtickStrings(table, deletedName)...),`
	`158`	`+ Text: fmt.Sprintf("Table %s: column %s removed from table", backtickStrings(table, deletedName)...),`
`159`	`159`	`Breaking: true,`
`160`	`160`	`})`
`161`	`161`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func Test_getChanges(t *testing.T) {`
`85`	`85`	`Breaking: true,`
`86`	`86`	`},`
`87`	`87`	`{`
`88`		- Text: "Table `azure_appservice_functions`: column removed `web_app_id` from table",
	`88`	+ Text: "Table `azure_appservice_functions`: column `web_app_id` removed from table",
`89`	`89`	`Breaking: true,`
`90`	`90`	`},`
`91`	`91`	`{`
`@@ -141,35 +141,35 @@ func Test_getChanges(t *testing.T) {`
`141`	`141`	`Breaking: true,`
`142`	`142`	`},`
`143`	`143`	`{`
`144`		- Text: "Table `azure_subscription_tenants`: column removed `name` from table",
	`144`	+ Text: "Table `azure_subscription_tenants`: column `name` removed from table",
`145`	`145`	`Breaking: true,`
`146`	`146`	`},`
`147`	`147`	`{`
`148`		- Text: "Table `azure_subscription_tenants`: column removed `properties_notes` from table",
	`148`	+ Text: "Table `azure_subscription_tenants`: column `properties_notes` removed from table",
`149`	`149`	`Breaking: true,`
`150`	`150`	`},`
`151`	`151`	`{`
`152`		- Text: "Table `azure_subscription_tenants`: column removed `properties_source_id` from table",
	`152`	+ Text: "Table `azure_subscription_tenants`: column `properties_source_id` removed from table",
`153`	`153`	`Breaking: true,`
`154`	`154`	`},`
`155`	`155`	`{`
`156`		- Text: "Table `azure_subscription_tenants`: column removed `properties_target_id` from table",
	`156`	+ Text: "Table `azure_subscription_tenants`: column `properties_target_id` removed from table",
`157`	`157`	`Breaking: true,`
`158`	`158`	`},`
`159`	`159`	`{`
`160`	`160`	Text: "Table `azure_subscription_tenants`: column added with name `tenant_id` and type `String`",
`161`	`161`	`Breaking: false,`
`162`	`162`	`},`
`163`	`163`	`{`
`164`		- Text: "Table `azure_subscriptions`: column removed `managed_by_tenants` from table",
	`164`	+ Text: "Table `azure_subscriptions`: column `managed_by_tenants` removed from table",
`165`	`165`	`Breaking: true,`
`166`	`166`	`},`
`167`	`167`	`{`
`168`		- Text: "Table `azure_subscriptions`: column removed `tags` from table",
	`168`	+ Text: "Table `azure_subscriptions`: column `tags` removed from table",
`169`	`169`	`Breaking: true,`
`170`	`170`	`},`
`171`	`171`	`{`
`172`		- Text: "Table `azure_subscriptions`: column removed `tenant_id` from table",
	`172`	+ Text: "Table `azure_subscriptions`: column `tenant_id` removed from table",
`173`	`173`	`Breaking: true,`
`174`	`174`	`},`
`175`	`175`	`{`