chore(diff): Handle list types (#10965)

candiduslynx · web-flow · commit 8fbcbae09cef · 2023-05-25T14:43:37.000Z
Inspired by #10797 (comment)
diff --git a/scripts/table_diff/changes/changes_test.go b/scripts/table_diff/changes/changes_test.go
@@ -366,6 +366,11 @@ func Test_getChanges(t *testing.T) {
 			diffDataFile: "testdata/pr_10831_diff.txt",
 			wantChanges:  []change{},
 		},
+		{
+			name:         "Should handle CQTypes -> Apache Arrow column changes with lists, too",
+			diffDataFile: "testdata/pr_10797_diff.txt",
+			wantChanges:  []change{},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
diff --git a/scripts/table_diff/changes/testdata/pr_10797_diff.txt b/scripts/table_diff/changes/testdata/pr_10797_diff.txt
@@ -0,0 +1,36 @@
+diff --git a/website/tables/aws/aws_wafv2_ipsets.md b/website/tables/aws/aws_wafv2_ipsets.md
+index e11625c29a5d..5b6a2f3d9512 100644
+--- a/website/tables/aws/aws_wafv2_ipsets.md
++++ b/website/tables/aws/aws_wafv2_ipsets.md
+@@ -10,16 +10,16 @@ The primary key for this table is **arn**.
+ 
+ | Name          | Type          |
+ | ------------- | ------------- |
+-|_cq_source_name|String|
+-|_cq_sync_time|Timestamp|
+-|_cq_id|UUID|
+-|_cq_parent_id|UUID|
+-|account_id|String|
+-|region|String|
+-|addresses|InetArray|
+-|tags|JSON|
+-|arn (PK)|String|
+-|ip_address_version|String|
+-|id|String|
+-|name|String|
+-|description|String|
+\ No newline at end of file
++|_cq_source_name|utf8|
++|_cq_sync_time|timestamp[us, tz=UTC]|
++|_cq_id|uuid|
++|_cq_parent_id|uuid|
++|account_id|utf8|
++|region|utf8|
++|addresses|list<item: inet, nullable>|
++|tags|json|
++|arn (PK)|utf8|
++|ip_address_version|utf8|
++|id|utf8|
++|name|utf8|
++|description|utf8|
+\ No newline at end of file
diff --git a/scripts/table_diff/changes/types.go b/scripts/table_diff/changes/types.go
@@ -17,8 +17,11 @@ func init() {
 
 	// extensions are special as we need v3/types for extensions (diff in `String` func)
 	cqToArrow[strings.TrimPrefix(schemav2.TypeUUID.String(), "Type")] = types.ExtensionTypes.UUID
+	cqToArrow[strings.TrimPrefix(schemav2.TypeUUIDArray.String(), "Type")] = arrow.ListOf(types.ExtensionTypes.UUID)
 	cqToArrow[strings.TrimPrefix(schemav2.TypeInet.String(), "Type")] = types.ExtensionTypes.Inet
+	cqToArrow[strings.TrimPrefix(schemav2.TypeInetArray.String(), "Type")] = arrow.ListOf(types.ExtensionTypes.Inet)
 	cqToArrow[strings.TrimPrefix(schemav2.TypeMacAddr.String(), "Type")] = types.ExtensionTypes.MAC
+	cqToArrow[strings.TrimPrefix(schemav2.TypeMacAddrArray.String(), "Type")] = arrow.ListOf(types.ExtensionTypes.MAC)
 	cqToArrow[strings.TrimPrefix(schemav2.TypeJSON.String(), "Type")] = types.ExtensionTypes.JSON
 }
 
