feat: Add sync duration ms to sync summary (#21712)

bbernays · web-flow · commit 80e01b367c19 · 2025-12-12T18:04:54.000Z
diff --git a/cli/cmd/summary.go b/cli/cmd/summary.go
@@ -35,6 +35,7 @@ type syncSummary struct {
 	SourceTables        []string          `json:"source_tables"`
 	SyncID              string            `json:"sync_id"`
 	SyncTime            time.Time         `json:"sync_time"`
+	SyncDurationMs      uint64            `json:"sync_duration_ms"`
 	SyncGroupID         *string           `json:"sync_group_id,omitempty"`
 	ShardNum            *int              `json:"shard_num,omitempty"`
 	ShardTotal          *int              `json:"shard_total,omitempty"`
diff --git a/cli/cmd/sync_test.go b/cli/cmd/sync_test.go
@@ -373,12 +373,13 @@ func TestSync(t *testing.T) {
 			if len(tc.summary) > 0 {
 				summaries := readSummaries(t, summaryPath)
 				// Ignore random fields or fields that are updated over time
-				diff := cmp.Diff(tc.summary, summaries, cmpopts.IgnoreFields(syncSummary{}, "SyncID", "DestinationVersion", "SourceVersion", "SyncTime"))
+				diff := cmp.Diff(tc.summary, summaries, cmpopts.IgnoreFields(syncSummary{}, "SyncID", "DestinationVersion", "SourceVersion", "SyncTime", "SyncDurationMs"))
 				for _, s := range summaries {
 					assert.NotEmpty(t, s.SyncID)
 					assert.NotEmpty(t, s.SyncTime)
 					assert.NotEmpty(t, s.DestinationVersion)
 					assert.NotEmpty(t, s.SourceVersion)
+					assert.Greater(t, s.SyncDurationMs, uint64(0))
 				}
 				require.Empty(t, diff, "unexpected summaries: %v", diff)
 			}
diff --git a/cli/cmd/sync_v3.go b/cli/cmd/sync_v3.go
@@ -632,7 +632,7 @@ func syncConnectionV3(ctx context.Context, syncOptions syncV3Options) (syncErr e
 			return acc
 		}, durationsPerTable)
 	}
-
+	syncTimeTook = time.Since(syncTime)
 	for i := range destinationsClients {
 		if destinationSpecs[i].WriteMode == specs.WriteModeOverwriteDeleteStale {
 			// Table names might have changed due to transformers
@@ -652,6 +652,7 @@ func syncConnectionV3(ctx context.Context, syncOptions syncV3Options) (syncErr e
 			SyncID:              uid,
 			SyncTime:            syncTime,
 			SourceName:          sourceSpec.Name,
+			SyncDurationMs:      uint64(syncTimeTook.Milliseconds()),
 			SourceVersion:       sourceSpec.Version,
 			SourcePath:          sourceSpec.Path,
 			SourceTables:        tableNameChanger.UpdateTableNamesSlice(destinationSpecs[i].Name, sourceTableNames),
@@ -702,7 +703,7 @@ func syncConnectionV3(ctx context.Context, syncOptions syncV3Options) (syncErr e
 	}
 
 	atomic.StoreInt64(&isComplete, 1)
-	syncTimeTook = time.Since(syncTime)
+
 	exitReason = ExitReasonCompleted
 
 	msg := "Sync completed successfully"
