fix(table-diff): Mark type changes as breaking (#6515)

erezrokah · web-flow · commit 779907c996ed · 2023-01-09T11:36:57.000+02:00
#### Summary While we [auto migrate type changes](https://github.com/cloudquery/cloudquery/blob/a4987ae191b9f5e660d29ca4a99f1469dd9e1fe7/plugins/destination/postgresql/client/migrate.go#LL110C8-L110C8) I believe those should still be considered breaking as they can impact how the data is queried
diff --git a/scripts/table_diff/changes/changes.go b/scripts/table_diff/changes/changes.go
@@ -101,7 +101,7 @@ func getColumnChanges(file *gitdiff.File, table string) (changes []change) {
 			if addedColumn.dataType != deletedColumn.dataType {
 				changes = append(changes, change{
 					Text:     fmt.Sprintf("Table %s: column type changed from %s to %s for %s", backtickStrings(table, deletedColumn.dataType, addedColumn.dataType, deletedName)...),
-					Breaking: false,
+					Breaking: true,
 				})
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ func getColumnChanges(file *gitdiff.File, table string) (changes []change) {`
`101`	`101`	`if addedColumn.dataType != deletedColumn.dataType {`
`102`	`102`	`changes = append(changes, change{`
`103`	`103`	`Text: fmt.Sprintf("Table %s: column type changed from %s to %s for %s", backtickStrings(table, deletedColumn.dataType, addedColumn.dataType, deletedName)...),`
`104`		`- Breaking: false,`
	`104`	`+ Breaking: true,`
`105`	`105`	`})`
`106`	`106`	`}`
`107`	`107`