chore: If both CLI and Scaffold are updated, validate both (#16958)

erezrokah · web-flow · commit 616c96af3add · 2024-02-28T23:29:08.000+02:00
#### Summary If both CLI and Scaffold were changed we should add `validate-release` for each one
diff --git a/scripts/workflows/wait_for_required_workflows.js b/scripts/workflows/wait_for_required_workflows.js
@@ -33,13 +33,13 @@ module.exports = async ({github, context}) => {
         return
     }
 
-    // Validate Go Releaser only if we are testing the CLI or scaffold
-    if (actions.includes("cli") || actions.includes("scaffold")) {
+    if (actions.includes("scaffold")) {
         actions = [...actions, 'validate-release']
     }
 
     // We test the CLI on multiple OSes, so we need to wait for all of them
     if (actions.includes("cli")) {
+        actions = [...actions, 'validate-release']
         actions = actions.filter(action => action !== "cli")
         actions = ["cli (ubuntu-latest)", "cli (windows-latest)", "cli (macos-latest)", ...actions]
     }

Original file line number	Diff line number	Diff line change
`@@ -33,13 +33,13 @@ module.exports = async ({github, context}) => {`
`33`	`33`	`return`
`34`	`34`	`}`
`35`	`35`
`36`		`- // Validate Go Releaser only if we are testing the CLI or scaffold`
`37`		`- if (actions.includes("cli") \|\| actions.includes("scaffold")) {`
	`36`	`+ if (actions.includes("scaffold")) {`
`38`	`37`	`actions = [...actions, 'validate-release']`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`// We test the CLI on multiple OSes, so we need to wait for all of them`
`42`	`41`	`if (actions.includes("cli")) {`
	`42`	`+ actions = [...actions, 'validate-release']`
`43`	`43`	`actions = actions.filter(action => action !== "cli")`
`44`	`44`	`actions = ["cli (ubuntu-latest)", "cli (windows-latest)", "cli (macos-latest)", ...actions]`
`45`	`45`	`}`