chore(cli): Use large runners (#11898)

yevgenypats · web-flow · commit 501fca765361 · 2023-07-03T13:37:44.000Z
#### Summary

&lt;!--
Explain what problem this PR addresses
--&gt;

&lt;!--
diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml
@@ -13,25 +13,6 @@ on:
       - ".github/workflows/cli.yml"
 
 jobs:
-  resolve-runner:
-    timeout-minutes: 5
-    runs-on: ubuntu-latest
-    outputs:
-      runner: ${{ steps.resolve.outputs.runner }}
-    steps:
-      - name: Check if should use large runner
-        id: large-runner
-        # We want to speed runs on the main branch which prime the cache
-        # We allow large runners only in this case to prevent forks from abusing them (it's enforced via runner groups access rules)
-        # IF YOU WANT TO USE A LARGE RUNNER YOU NEED TO ADD THE WORKFLOW TO THE `CloudQuery releases` GROUP IN https://github.com/organizations/cloudquery/settings/actions/runner-groups
-        if: github.event_name == 'push'
-        run: |
-          echo "runner=cloudquery-release-runner" >> $GITHUB_OUTPUT
-      - name: Resolve runner
-        id: resolve
-        run: |
-          RUNNER=${{ steps.large-runner.outputs.runner }}
-          echo "runner=${RUNNER:-"ubuntu-latest"}" >> $GITHUB_OUTPUT
   cli:
     timeout-minutes: 30
     name: "cli"
@@ -42,7 +23,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ubuntu-cli-large-runner, macos-latest, windows-cli-large-runner]
     steps:
       - uses: actions/checkout@v3
         with:
@@ -55,7 +36,7 @@ jobs:
           cache-dependency-path: cli/go.sum
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
-        if: matrix.os == 'ubuntu-latest'
+        if: matrix.os == 'ubuntu-cli-large-runner'
         with:
           version: v1.52.2
           working-directory: cli
@@ -66,15 +47,14 @@ jobs:
       - name: Test
         run: make test
       - name: gen-docs
-        if: matrix.os == 'ubuntu-latest'
+        if: matrix.os == 'ubuntu-cli-large-runner'
         run: make gen-docs
       - name: Fail if docs are changed
-        if: matrix.os == 'ubuntu-latest'
+        if: matrix.os == 'ubuntu-cli-large-runner'
         run: test "$(git status -s ../website/pages/docs/reference/cli/*.md | wc -l)" -eq 0
   validate-release:
     timeout-minutes: 30
-    needs: [resolve-runner]
-    runs-on: ${{ needs.resolve-runner.outputs.runner }}
+    runs-on: ubuntu-cli-large-runner
     env:
       CGO_ENABLED: 0
     steps:
@@ -87,9 +67,9 @@ jobs:
           path: |
             ~/.cache/go-build
             ~/go/pkg/mod
-          key: ${{ runner.os }}-go-1.19.5-release-cache-${{ hashFiles('cli/go.sum') }}
+          key: ubuntu-go-1.19.5-release-cache-${{ hashFiles('cli/go.sum') }}
           restore-keys: |
-            ${{ runner.os }}-go-1.19.5-release-cache-cli
+            ubuntu-go-1.19.5-release-cache-cli
       - name: Set up Go
         if: startsWith(github.head_ref, 'release-please--branches--main--components') || github.event_name == 'push'
         uses: actions/setup-go@v3
diff --git a/scripts/workflows/wait_for_required_workflows.js b/scripts/workflows/wait_for_required_workflows.js
@@ -41,7 +41,7 @@ module.exports = async ({github, context}) => {
     // We test the CLI on multiple OSes, so we need to wait for all of them
     if (actions.includes("cli")) {
         actions = actions.filter(action => action !== "cli")
-        actions = ["cli (ubuntu-latest)", "cli (windows-latest)", "cli (macos-latest)", ...actions]
+        actions = ["cli (ubuntu-cli-large-runner)", "cli (windows-cli-large-runner)", "cli (macos-latest)", ...actions]
     }
 
     // Enforce policy tests for AWS,GCP and K8s plugins

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ module.exports = async ({github, context}) => {`
`41`	`41`	`// We test the CLI on multiple OSes, so we need to wait for all of them`
`42`	`42`	`if (actions.includes("cli")) {`
`43`	`43`	`actions = actions.filter(action => action !== "cli")`
`44`		`- actions = ["cli (ubuntu-latest)", "cli (windows-latest)", "cli (macos-latest)", ...actions]`
	`44`	`+ actions = ["cli (ubuntu-cli-large-runner)", "cli (windows-cli-large-runner)", "cli (macos-latest)", ...actions]`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`// Enforce policy tests for AWS,GCP and K8s plugins`