fix: DeleteStale from relational tables as well (#5143)

shimonp21 · yevgenypats · web-flow · commit 23aa1597a2db · 2022-11-29T16:11:32.000+02:00
#### Summary Won't compile until cloudquery/plugin-sdk#443 is merged.  Co-authored-by: Yevgeny Pats <yev.pats@gmail.com>
diff --git a/plugins/destination/postgresql/client/deletestale.go b/plugins/destination/postgresql/client/deletestale.go
@@ -12,7 +12,7 @@ import (
 
 func (c *Client) DeleteStale(ctx context.Context, tables schema.Tables, source string, syncTime time.Time) error {
 	batch := &pgx.Batch{}
-	for _, table := range tables {
+	for _, table := range tables.FlattenTables() {
 		var sb strings.Builder
 		sb.WriteString("delete from ")
 		sb.WriteString(pgx.Identifier{table.Name}.Sanitize())
diff --git a/plugins/destination/snowflake/client/deletestale.go b/plugins/destination/snowflake/client/deletestale.go
@@ -9,7 +9,7 @@ import (
 )
 
 func (c *Client) DeleteStale(ctx context.Context, tables schema.Tables, source string, syncTime time.Time) error {
-	for _, table := range tables {
+	for _, table := range tables.FlattenTables() {
 		var sb strings.Builder
 		sb.WriteString("delete from ")
 		sb.WriteString(table.Name)
diff --git a/plugins/destination/sqlite/client/deletestale.go b/plugins/destination/sqlite/client/deletestale.go
@@ -9,7 +9,7 @@ import (
 )
 
 func (c *Client) DeleteStale(ctx context.Context, tables schema.Tables, source string, syncTime time.Time) error {
-	for _, table := range tables {
+	for _, table := range tables.FlattenTables() {
 		var sb strings.Builder
 		sb.WriteString("delete from ")
 		sb.WriteString(`"` + table.Name + `"`)

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import (`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`func (c *Client) DeleteStale(ctx context.Context, tables schema.Tables, source string, syncTime time.Time) error {`
`12`		`- for _, table := range tables {`
	`12`	`+ for _, table := range tables.FlattenTables() {`
`13`	`13`	`var sb strings.Builder`
`14`	`14`	`sb.WriteString("delete from ")`
`15`	`15`	`sb.WriteString(table.Name)`