chore(diff): Ignore backticks (#11028)

candiduslynx · web-flow · commit 054b9085a3e5 · 2023-05-26T15:04:17.000Z
Follow-up for cloudquery/plugin-sdk#908
diff --git a/scripts/table_diff/changes/changes.go b/scripts/table_diff/changes/changes.go
@@ -68,7 +68,7 @@ func parseColumnChange(line string) (name string, dataType string, columnType co
 		columnType |= columnTypeIncremental
 	}
 	cleanName := strings.Split(result["name"], " (")[0]
-	return cleanName, result["dataType"], columnType
+	return cleanName, strings.Trim(result["dataType"], "`"), columnType
 }
 
 func parsePKChange(line string) (names []string) {
diff --git a/scripts/table_diff/changes/changes_test.go b/scripts/table_diff/changes/changes_test.go
@@ -366,6 +366,11 @@ func Test_getChanges(t *testing.T) {
 			diffDataFile: "testdata/pr_10831_diff.txt",
 			wantChanges:  []change{},
 		},
+		{
+			name:         "Should handle CQTypes -> Apache Arrow column changes with backticks, too",
+			diffDataFile: "testdata/pr_10831_diff_backtick.txt",
+			wantChanges:  []change{},
+		},
 		{
 			name:         "Should handle CQTypes -> Apache Arrow column changes with lists, too",
 			diffDataFile: "testdata/pr_10797_diff.txt",
diff --git a/scripts/table_diff/changes/testdata/pr_10831_diff_backtick.txt b/scripts/table_diff/changes/testdata/pr_10831_diff_backtick.txt
@@ -0,0 +1,46 @@
+diff --git a/website/tables/hackernews/hackernews_items.md b/website/tables/hackernews/hackernews_items.md
+index 27915dd5235b..2cbb11f5eb4c 100644
+--- a/website/tables/hackernews/hackernews_items.md
++++ b/website/tables/hackernews/hackernews_items.md
+@@ -11,21 +11,21 @@ It supports incremental syncs based on the **id** column.
+ 
+ | Name          | Type          |
+ | ------------- | ------------- |
+-|_cq_source_name|String|
+-|_cq_sync_time|Timestamp|
+-|_cq_id|UUID|
+-|_cq_parent_id|UUID|
+-|id (PK) (Incremental Key)|Int|
+-|deleted|Bool|
+-|type|String|
+-|by|String|
+-|time|Timestamp|
+-|text|String|
+-|dead|Bool|
+-|parent|Int|
+-|kids|IntArray|
+-|url|String|
+-|score|Int|
+-|title|String|
+-|parts|IntArray|
+-|descendants|Int|
+\ No newline at end of file
++|_cq_source_name|`utf8`|
++|_cq_sync_time|`timestamp[us, tz=UTC]`|
++|_cq_id|`uuid`|
++|_cq_parent_id|`uuid`|
++|id (PK) (Incremental Key)|`int64`|
++|deleted|`bool`|
++|type|`utf8`|
++|by|`utf8`|
++|time|`timestamp[us, tz=UTC]`|
++|text|`utf8`|
++|dead|`bool`|
++|parent|`int64`|
++|kids|`list<item: int64, nullable>`|
++|url|`utf8`|
++|score|`int64`|
++|title|`utf8`|
++|parts|`list<item: int64, nullable>`|
++|descendants|`int64`|
+\ No newline at end of file

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func parseColumnChange(line string) (name string, dataType string, columnType co`
`68`	`68`	`columnType \|= columnTypeIncremental`
`69`	`69`	`}`
`70`	`70`	`cleanName := strings.Split(result["name"], " (")[0]`
`71`		`- return cleanName, result["dataType"], columnType`
	`71`	+ return cleanName, strings.Trim(result["dataType"], "`"), columnType
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`func parsePKChange(line string) (names []string) {`