chore: Switch to git based diffing instead of API diffing (#14467)

erezrokah · web-flow · commit 04916a6b37a5 · 2023-10-09T11:43:22.000+03:00
#### Summary Should help with #14464 hopefully. This changes our CI to use git based diffing instead of the GitHub API. Also changes the polling internal to 15s instead of 5s
diff --git a/.github/workflows/wait_for_required_workflows.yml b/.github/workflows/wait_for_required_workflows.yml
@@ -3,7 +3,7 @@ name: Wait for all required workflows to pass
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
-  
+
 on:
   pull_request:
     branches:
@@ -15,13 +15,15 @@ jobs:
     name: wait-for-required-workflows
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
       - name: Get changed files
         id: changed-files
-        uses: Ana06/get-changed-files@v2.2.0
+        uses: tj-actions/changed-files@v39
       - uses: actions/github-script@v6
         env:
-          FILES: ${{ steps.changed-files.outputs.all }}
+          FILES: ${{ steps.changed-files.outputs.all_changed_files }}
         with:
           script: |
             const script = require('./scripts/workflows/wait_for_required_workflows.js')
diff --git a/scripts/workflows/wait_for_required_workflows.js b/scripts/workflows/wait_for_required_workflows.js
@@ -78,7 +78,7 @@ module.exports = async ({github, context}) => {
         }
         pendingActions = actions.filter(action => !runs.some(({name}) => name === action))
         console.log(`Waiting for ${pendingActions.join(", ")}`)
-        await new Promise(r => setTimeout(r, 5000));
+        await new Promise(r => setTimeout(r, 15000));
         now = new Date().getTime()
     }
     throw new Error(`Timed out waiting for ${pendingActions.join(', ')}`)

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ module.exports = async ({github, context}) => {`
`78`	`78`	`}`
`79`	`79`	`pendingActions = actions.filter(action => !runs.some(({name}) => name === action))`
`80`	`80`	console.log(`Waiting for ${pendingActions.join(", ")}`)
`81`		`- await new Promise(r => setTimeout(r, 5000));`
	`81`	`+ await new Promise(r => setTimeout(r, 15000));`
`82`	`82`	`now = new Date().getTime()`
`83`	`83`	`}`
`84`	`84`	throw new Error(`Timed out waiting for ${pendingActions.join(', ')}`)