If you want to contribute to the source code of CloudNativePG and innovate in the database in Kubernetes space, this is the right place. Welcome!
We have a truly open source soul. That's why we welcome new contributors. Our goal is to enable you to become the next committer of CloudNativePG, by having a good set of docs that guide you through the development process. Having said this, we know that everything can always be improved, so if you think our documentation is not enough, let us know or provide a pull request based on your experience.
If you have any questions or need guidance, feel free to reach out in the #cloudnativepg-dev channel on the CNCF Slack workspace.
CloudNativePG follows trunk-based development,
with the main branch representing the trunk.
We adopt the "Github Flow" development workflow, with some customizations:
- the Continuous Delivery
branch is called
mainand is protected - Github is configured for linear development (no merge commits)
- development happens in separate branches created from the
mainbranch and called "dev/ISSUE_ID" - once completed, developers must submit a pull request
- two reviews by different maintainers are required before a pull request can be merged
We adopt the conventional commit format for commit messages.
The roadmap is defined as a Github Project.
We have an operational Kanban board we use to organize the flow of items.
If you are new to the project, we recommend starting with the Technical Architecture document, which describes the core design principles and reconciliation architecture of CloudNativePG.
If you want to test or evaluate the latest development snapshot of CloudNativePG before the next official patch release, you can simply run:
kubectl apply --server-side -f \
https://raw.githubusercontent.com/cloudnative-pg/artifacts/main/manifests/operator-manifest.yamlIn order to write even the simplest patch for CloudNativePG you must have setup your workstation to build and locally test the version of the operator you are developing. All you have to do is follow the instructions you find in "Setting up your development environment for CloudNativePG".
Can you manually test your patch for all the supported PostgreSQL versions on all the supported Kubernetes versions? You probably agree this is not feasible (have you ever heard of the inverted pyramid of testing?).
This is the reason why we have invested since day 1 of CloudNativePG in automated testing. Please refer to "Running E2E tests on your environment" for detailed information.
First and foremost: as a potential contributor, your changes and ideas are welcome at any hour of the day or night, weekdays, weekends, and holidays. Please do not ever hesitate to ask a question or send a PR.
IMPORTANT: before you submit a pull request, please read this document from the Istio documentation which contains very good insights and best practices: "Writing Good Pull Requests".
If you have written code for an improvement to CloudNativePG or a bug fix, please follow this procedure to submit a pull request:
-
Create a fork of CloudNativePG
-
External contributors: Comment on the issue with "I'd like to work on this" and wait for assignment. Maintainers: Self-assign the ticket and move it to
AnalysisorIn Developmentphase of CloudNativePG operator development -
External contributors: Run local unit tests and basic e2e tests using
FEATURE_TYPE=smoke,basic make e2e-test-kindorTEST_DEPTH=0 make e2e-test-kindfor critical tests only. Maintainers: Run the comprehensive e2e tests in the forked repository -
Once development is finished, create a pull request from your forked project to the CloudNativePG project. Maintainers will move the ticket to the
Waiting for First Reviewphase.Please make sure the pull request title and message follow Conventional Commits
To facilitate collaboration, always allow edits by maintainers
One of the maintainers will then proceed with the first review and approve the
CI workflow to run in the CloudNativePG project. The second reviewer will run
end-to-end test against the changes in fork pull request. If testing passes,
the pull request will be labeled with ok-to-merge and will be ready for
merge.
We use the Developer Certificate of Origin (DCO) as an additional safeguard for the CloudNativePG project. This is a well established and widely used mechanism to assure contributors have confirmed their right to license their contribution under the project's license. Please read developer-certificate-of-origin.
If you can certify it, then just add a line to every git commit message:
Signed-off-by: Random J Developer <random@developer.example.org>
or use the command git commit -s -m "commit message comes here" to sign-off on your commits.
Use your real name (sorry, no pseudonyms or anonymous contributions).
If you set your user.name and user.email git configs, you can sign your
commit automatically with git commit -s.
You can also use git aliases
like git config --global alias.ci 'commit -s'. Now you can commit with git ci and the
commit will be signed.