Fix CloudFoundry protocol compliance in finalize phase

ramonskie · ramonskie · commit f69c7000dc9c · 2025-12-05T11:46:36.000+01:00
- Add stager.SetStagingEnvironment() call before finalize logic
- Add stager.StagingComplete() call at end of finalize
- Remove unnecessary calls (CheckBuildpackValid, SetAppCacheDir, WriteConfigYml, CleanupAppCache)
- Align exit codes with reference buildpacks (go-buildpack, ruby-buildpack)

Fixes ensure proper CloudFoundry lifecycle signaling
diff --git a/src/java/finalize/cli/main.go b/src/java/finalize/cli/main.go
@@ -36,20 +36,16 @@ func main() {
 	installer := libbuildpack.NewInstaller(manifest)
 	stager := libbuildpack.NewStager(os.Args[1:], logger, manifest)
 
-	if err := stager.CheckBuildpackValid(); err != nil {
-		os.Exit(11)
-	}
-
-	if err = installer.SetAppCacheDir(stager.CacheDir()); err != nil {
-		logger.Error("Unable to setup appcache: %s", err)
-		os.Exit(18)
-	}
-
 	if err = manifest.ApplyOverride(stager.DepsDir()); err != nil {
 		logger.Error("Unable to apply override.yml files: %s", err)
 		os.Exit(17)
 	}
 
+	if err := stager.SetStagingEnvironment(); err != nil {
+		logger.Error("Unable to setup environment variables: %s", err.Error())
+		os.Exit(10)
+	}
+
 	f := finalize.Finalizer{
 		Stager:    stager,
 		Manifest:  manifest,
@@ -59,7 +55,7 @@ func main() {
 	}
 
 	if err = finalize.Run(&f); err != nil {
-		os.Exit(14)
+		os.Exit(12)
 	}
 
 	if err := libbuildpack.RunAfterCompile(stager); err != nil {
@@ -69,16 +65,8 @@ func main() {
 
 	if err := stager.SetLaunchEnvironment(); err != nil {
 		logger.Error("Unable to setup launch environment: %s", err.Error())
-		os.Exit(16)
-	}
-
-	if err := stager.WriteConfigYml(nil); err != nil {
-		logger.Error("Error writing config.yml: %s", err.Error())
-		os.Exit(15)
+		os.Exit(14)
 	}
 
-	if err = installer.CleanupAppCache(); err != nil {
-		logger.Error("Unable to clean up app cache: %s", err)
-		os.Exit(19)
-	}
+	stager.StagingComplete()
 }
