Update framework name for JMX to be inline with other frameworks (#1216)

stokpop · web-flow · commit c75e7055b788 · 2026-03-19T16:09:28.000+01:00
* Just show JMX name for consistent framework naming, not jmx=&lt;port&gt;. Note: "JMX enabled on port %d" shows port already.

* Consistent frameworks logging, with brackets and commas.
diff --git a/src/java/finalize/finalize.go b/src/java/finalize/finalize.go
@@ -175,7 +175,7 @@ func (f *Finalizer) finalizeFrameworks(ctx *common.Context) error {
 		return nil
 	}
 
-	f.Log.Info("Finalizing frameworks: %v", strings.Join(frameworkNames, ","))
+	f.Log.Info("Finalizing frameworks: [%v]", strings.Join(frameworkNames, ","))
 
 	for i, framework := range detectedFrameworks {
 		f.Log.Info("Finalizing framework: %s", frameworkNames[i])
diff --git a/src/java/frameworks/jmx.go b/src/java/frameworks/jmx.go
@@ -2,9 +2,10 @@ package frameworks
 
 import (
 	"fmt"
-	"github.com/cloudfoundry/java-buildpack/src/java/common"
 	"os"
 	"strconv"
+
+	"github.com/cloudfoundry/java-buildpack/src/java/common"
 )
 
 // JmxFramework implements JMX (Java Management Extensions) support
@@ -30,8 +31,7 @@ func (j *JmxFramework) Detect() (string, error) {
 		return "", nil
 	}
 
-	port := config.getPort()
-	return fmt.Sprintf("jmx=%d", port), nil
+	return "JMX", nil
 }
 
 // Supply performs JMX setup during supply phase
diff --git a/src/java/supply/supply.go b/src/java/supply/supply.go
@@ -2,6 +2,8 @@ package supply
 
 import (
 	"fmt"
+	"strings"
+
 	"github.com/cloudfoundry/java-buildpack/src/java/common"
 
 	"github.com/cloudfoundry/java-buildpack/src/java/containers"
@@ -150,7 +152,7 @@ func (s *Supplier) installFrameworks() error {
 		return nil
 	}
 
-	s.Log.Info("Detected frameworks: %v", frameworkNames)
+	s.Log.Info("Detected frameworks: [%v]", strings.Join(frameworkNames, ","))
 
 	// Install all detected frameworks
 	// Framework installation errors are fatal and will abort the build,

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ func (f Finalizer) finalizeFrameworks(ctx common.Context) error {`
`175`	`175`	`return nil`
`176`	`176`	`}`
`177`	`177`
`178`		`- f.Log.Info("Finalizing frameworks: %v", strings.Join(frameworkNames, ","))`
	`178`	`+ f.Log.Info("Finalizing frameworks: [%v]", strings.Join(frameworkNames, ","))`
`179`	`179`
`180`	`180`	`for i, framework := range detectedFrameworks {`
`181`	`181`	`f.Log.Info("Finalizing framework: %s", frameworkNames[i])`
Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,10 @@ package frameworks`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`		`- "github.com/cloudfoundry/java-buildpack/src/java/common"`
`6`	`5`	`"os"`
`7`	`6`	`"strconv"`
	`7`	`+`
	`8`	`+ "github.com/cloudfoundry/java-buildpack/src/java/common"`
`8`	`9`	`)`
`9`	`10`
`10`	`11`	`// JmxFramework implements JMX (Java Management Extensions) support`
`@@ -30,8 +31,7 @@ func (j *JmxFramework) Detect() (string, error) {`
`30`	`31`	`return "", nil`
`31`	`32`	`}`
`32`	`33`
`33`		`- port := config.getPort()`
`34`		`- return fmt.Sprintf("jmx=%d", port), nil`
	`34`	`+ return "JMX", nil`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`// Supply performs JMX setup during supply phase`