add commas to frameworks log, update JMX framework name

stokpop · stokpop · commit 382deed83681 · 2026-01-15T10:17:27.000+01:00
diff --git a/src/java/finalize/finalize.go b/src/java/finalize/finalize.go
@@ -2,9 +2,11 @@ package finalize
 
 import (
 	"fmt"
-	"github.com/cloudfoundry/java-buildpack/src/java/common"
 	"os"
 	"path/filepath"
+	"strings"
+
+	"github.com/cloudfoundry/java-buildpack/src/java/common"
 
 	"github.com/cloudfoundry/java-buildpack/src/java/containers"
 	"github.com/cloudfoundry/java-buildpack/src/java/frameworks"
@@ -157,7 +159,7 @@ func (f *Finalizer) finalizeFrameworks() error {
 		return nil
 	}
 
-	f.Log.Info("Finalizing frameworks: %v", frameworkNames)
+	f.Log.Info("Finalizing frameworks: %v", strings.Join(frameworkNames, ","))
 
 	// Finalize all detected frameworks
 	for i, framework := range detectedFrameworks {
diff --git a/src/java/frameworks/cf_metrics_exporter.go b/src/java/frameworks/cf_metrics_exporter.go
@@ -40,7 +40,7 @@ func (f *CfMetricsExporterFramework) Detect() (string, error) {
 		if err != nil {
 			return "", fmt.Errorf("cf-metrics-exporter version not found in manifest: %w", err)
 		}
-		return fmt.Sprintf("cf-metrics-exporter-%s", version), nil
+		return fmt.Sprintf("%s (%s)", version.Name, version.Version), nil
 	}
 	return "", nil
 }
diff --git a/src/java/frameworks/jmx.go b/src/java/frameworks/jmx.go
@@ -2,9 +2,10 @@ package frameworks
 
 import (
 	"fmt"
-	"github.com/cloudfoundry/java-buildpack/src/java/common"
 	"os"
 	"strconv"
+
+	"github.com/cloudfoundry/java-buildpack/src/java/common"
 )
 
 // JmxFramework implements JMX (Java Management Extensions) support
@@ -27,7 +28,7 @@ func (j *JmxFramework) Detect() (string, error) {
 	}
 
 	port := j.getPort()
-	return fmt.Sprintf("jmx=%d", port), nil
+	return fmt.Sprintf("JMX (port %d)", port), nil
 }
 
 // Supply performs JMX setup during supply phase

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func (f *CfMetricsExporterFramework) Detect() (string, error) {`
`40`	`40`	`if err != nil {`
`41`	`41`	`return "", fmt.Errorf("cf-metrics-exporter version not found in manifest: %w", err)`
`42`	`42`	`}`
`43`		`- return fmt.Sprintf("cf-metrics-exporter-%s", version), nil`
	`43`	`+ return fmt.Sprintf("%s (%s)", version.Name, version.Version), nil`
`44`	`44`	`}`
`45`	`45`	`return "", nil`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,10 @@ package frameworks`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`		`- "github.com/cloudfoundry/java-buildpack/src/java/common"`
`6`	`5`	`"os"`
`7`	`6`	`"strconv"`
	`7`	`+`
	`8`	`+ "github.com/cloudfoundry/java-buildpack/src/java/common"`
`8`	`9`	`)`
`9`	`10`
`10`	`11`	`// JmxFramework implements JMX (Java Management Extensions) support`
`@@ -27,7 +28,7 @@ func (j *JmxFramework) Detect() (string, error) {`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`port := j.getPort()`
`30`		`- return fmt.Sprintf("jmx=%d", port), nil`
	`31`	`+ return fmt.Sprintf("JMX (port %d)", port), nil`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`// Supply performs JMX setup during supply phase`