Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudfoundry/commandrunner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: cloudfoundry/commandrunner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: remove-resolve-windows
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 19, 2017

  1. Remove resolve func from windows_command_runner.go 

    * As far as I can tell this never actually worked ...
* It was also removed from linux_command_runner.go in this commit:
cloudfoundry-attic/gunk@2bb7ab0
but not from windows_command_runner.go, so should be fine to delete it
* The reason for removing the func is that it resulted in commands with
both args[0] AND args[1] set to the path

[#145185373]

Signed-off-by: Konstantinos Karampogias <konstantinos.karampogias@swisscom.com>
    @teddyking @karampok
    teddyking authored and karampok committed May 19, 2017
    Configuration menu
    Copy the full SHA
    b4f00c2 View commit details
    Browse the repository at this point in the history
Loading