last-one-in-wins for refers and interns, warns on replacement

richhickey · richhickey · commit ab9a567faecc · 2010-05-04T13:09:05.000-04:00
diff --git a/src/jvm/clojure/lang/Compiler.java b/src/jvm/clojure/lang/Compiler.java
@@ -407,8 +407,9 @@ else if(!(RT.second(form) instanceof Symbol))
 			if(!v.ns.equals(currentNS()))
 				{
 				if(sym.ns == null)
-					throw new Exception("Name conflict, can't def " + sym + " because namespace: " + currentNS().name +
-					                    " refers to:" + v);
+					v = currentNS().intern(sym);
+//					throw new Exception("Name conflict, can't def " + sym + " because namespace: " + currentNS().name +
+//					                    " refers to:" + v);
 				else
 					throw new Exception("Can't create defs outside of current ns");
 				}
diff --git a/src/jvm/clojure/lang/Namespace.java b/src/jvm/clojure/lang/Namespace.java
@@ -14,6 +14,7 @@
 
 import java.io.ObjectStreamException;
 import java.io.Serializable;
+import java.io.PrintWriter;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.atomic.AtomicReference;
 
@@ -66,7 +67,23 @@ public Var intern(Symbol sym){
 	if(o instanceof Var && ((Var) o).ns == this)
 		return (Var) o;
 
-	throw new IllegalStateException(sym + " already refers to: " + o + " in namespace: " + name);
+//	throw new IllegalStateException(sym + " already refers to: " + o + " in namespace: " + name);
+
+	if(v == null)
+		v = new Var(this, sym);
+
+	warnOnReplace(sym, o, v);
+
+
+	while(!mappings.compareAndSet(map, map.assoc(sym, v)))
+		map = getMappings();
+
+	return v;
+}
+
+private void warnOnReplace(Symbol sym, Object o, Object v){
+	((PrintWriter) RT.ERR.deref()).println("WARNING: " + sym + " already refers to: " + o + " in namespace: " + name
+		+ ", being replaced by: " + v);
 }
 
 Object reference(Symbol sym, Object val){
@@ -85,7 +102,14 @@ Object reference(Symbol sym, Object val){
 	if(o == val)
 		return o;
 
-	throw new IllegalStateException(sym + " already refers to: " + o + " in namespace: " + name);
+//	throw new IllegalStateException(sym + " already refers to: " + o + " in namespace: " + name);
+	warnOnReplace(sym, o, val);
+
+	while(!mappings.compareAndSet(map, map.assoc(sym, val)))
+		map = getMappings();
+
+	return val;
+
 }
 
 public static boolean areDifferentInstancesOfSameClassName(Class cls1, Class cls2) {

Original file line number	Diff line number	Diff line change
`@@ -407,8 +407,9 @@ else if(!(RT.second(form) instanceof Symbol))`
`407`	`407`	`if(!v.ns.equals(currentNS()))`
`408`	`408`	`{`
`409`	`409`	`if(sym.ns == null)`
`410`		`- throw new Exception("Name conflict, can't def " + sym + " because namespace: " + currentNS().name +`
`411`		`- " refers to:" + v);`
	`410`	`+ v = currentNS().intern(sym);`
	`411`	`+// throw new Exception("Name conflict, can't def " + sym + " because namespace: " + currentNS().name +`
	`412`	`+// " refers to:" + v);`
`412`	`413`	`else`
`413`	`414`	`throw new Exception("Can't create defs outside of current ns");`
`414`	`415`	`}`