#378 set thread names on agent thread pools

Alex Miller · stuarthalloway · commit 351e05a24274 · 2010-10-12T19:46:37.000-04:00
Signed-off-by: Stuart Halloway &lt;stu@thinkrelevance.com&gt;
diff --git a/src/jvm/clojure/lang/Agent.java b/src/jvm/clojure/lang/Agent.java
@@ -12,9 +12,11 @@
 
 package clojure.lang;
 
-import java.util.concurrent.*;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.atomic.AtomicReference;
-import java.util.Map;
 
 public class Agent extends ARef {
 
@@ -34,18 +36,33 @@ public ActionQueue( IPersistentStack q, Throwable error )
 static final Keyword FAIL = Keyword.intern(null, "fail");
 
 volatile Object state;
-    AtomicReference<ActionQueue> aq = new AtomicReference(ActionQueue.EMPTY);
+    AtomicReference<ActionQueue> aq = new AtomicReference<ActionQueue>(ActionQueue.EMPTY);
 
     volatile Keyword errorMode = CONTINUE;
     volatile IFn errorHandler = null;
 
+final private static AtomicLong sendThreadPoolCounter = new AtomicLong(0);
+
+final private static AtomicLong sendOffThreadPoolCounter = new AtomicLong(0);
+
 final public static ExecutorService pooledExecutor =
-		Executors.newFixedThreadPool(2 + Runtime.getRuntime().availableProcessors());
+	Executors.newFixedThreadPool(2 + Runtime.getRuntime().availableProcessors(), 
+		createThreadFactory("clojure-agent-send-pool-%d", sendThreadPoolCounter));
 
-final public static ExecutorService soloExecutor = Executors.newCachedThreadPool();
+final public static ExecutorService soloExecutor = Executors.newCachedThreadPool(
+	createThreadFactory("clojure-agent-send-off-pool-%d", sendOffThreadPoolCounter));
 
 final static ThreadLocal<IPersistentVector> nested = new ThreadLocal<IPersistentVector>();
 
+private static ThreadFactory createThreadFactory(final String format, final AtomicLong threadPoolCounter) {
+	return new ThreadFactory() {
+		@Override public Thread newThread(Runnable runnable) {
+			Thread thread = new Thread(runnable);
+			thread.setName(String.format(format, threadPoolCounter.getAndIncrement()));
+			return thread;
+		}
+	};
+}
 
 public static void shutdown(){
 	soloExecutor.shutdown();
