Skip to content

Commit 895dca2

Browse files
pipboy96Hainish
authored andcommitted
Get rid of --privileged in Docker command line (EFForg#17376)
1 parent e0c8429 commit 895dca2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/run_travis.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ elif [ "$TEST" == "validations" ] || [ "$TEST" == "fetch" ] || [ "$TEST" == "pre
7979

8080
if [ "$TEST" == "fetch" ]; then
8181
echo >&2 "Testing test URLs in all changed rulesets."
82-
# --privileged is required here for miredo to create a network tunnel
83-
docker run --rm -ti -v $(pwd):/opt -e RULESETS_CHANGED="$RULESETS_CHANGED" --privileged httpse bash -c "echo 0 > /proc/sys/net/ipv6/conf/all/disable_ipv6 && service miredo start && service tor start && test/fetch.sh"
82+
# NET_ADMIN capability is required here for miredo to create a network tunnel
83+
docker run --rm -ti -v $(pwd):/opt -e RULESETS_CHANGED="$RULESETS_CHANGED" --sysctl net.ipv6.conf.all.disable_ipv6=0 --cap-add NET_ADMIN --cap-add MKNOD httpse bash -c "mkdir -p /dev/net && mknod /dev/net/tun c 10 200 && service miredo start && service tor start && test/fetch.sh"
8484
fi
8585

8686
if [ "$TEST" == "preloaded" ]; then

0 commit comments

Comments
 (0)