Fix OpenCensus thread cleanup error and other issues. (GoogleCloudPlatform#1246)

dzlier-gcp · web-flow · commit c02460bca6ba · 2018-11-01T15:58:50.000-07:00
diff --git a/opencensus/pom.xml b/opencensus/pom.xml
@@ -74,6 +74,7 @@
         </executions>
         <configuration>
           <mainClass>com.example.opencensus.Quickstart</mainClass>
+          <cleanupDaemonThreads>false</cleanupDaemonThreads>
         </configuration>
       </plugin>
     </plugins>
diff --git a/opencensus/src/main/java/com/example/opencensus/Quickstart.java b/opencensus/src/main/java/com/example/opencensus/Quickstart.java
@@ -51,7 +51,7 @@ public static void main(String[] args) throws IOException, InterruptedException
     // Register the view. It is imperative that this step exists,
     // otherwise recorded metrics will be dropped and never exported.
     View view = View.create(
-        Name.create("task_latency_distribution_4"),
+        Name.create("task_latency_distribution"),
         "The distribution of the task latencies.",
         LATENCY_MS,
         Aggregation.Distribution.create(LATENCY_BOUNDARIES),
@@ -68,7 +68,6 @@ public static void main(String[] args) throws IOException, InterruptedException
     StackdriverStatsExporter.createAndRegister();
     // [END setup_exporter]
 
-    // [START example_code]
     // Record 100 fake latency values between 0 and 5 seconds.
     Random rand = new Random();
     for (int i = 0; i < 100; i++) {
@@ -81,8 +80,9 @@ public static void main(String[] args) throws IOException, InterruptedException
     // live for at least the interval past any metrics that must be collected, or some risk being
     // lost if they are recorded after the last export.
 
+    System.out.println(String.format(
+        "Sleeping %d seconds before shutdown to ensure all records are flushed.", EXPORT_INTERVAL));
     Thread.sleep(TimeUnit.MILLISECONDS.convert(EXPORT_INTERVAL, TimeUnit.SECONDS));
-    // [END example_code]
   }
 }
 // [END monitoring_opencensus_metrics_quickstart]
