From 0dd18d9c277239c641d8f37973aea934bb0feb0c Mon Sep 17 00:00:00 2001 From: Matt Tuusberg Date: Tue, 4 Feb 2025 15:49:43 +0300 Subject: [PATCH 1/3] chore: cleanup code --- Makefile | 2 +- src/dedup-tranport.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index d86c1d0..945d987 100644 --- a/Makefile +++ b/Makefile @@ -5,4 +5,4 @@ release: ifeq ($(TAG),) $(error "TAG is undefined, aborting") endif - npm version "${TAG}" -s -m "chore: %s version" + npm version "${TAG}" -s -m "chore: %s version" diff --git a/src/dedup-tranport.ts b/src/dedup-tranport.ts index f568e4d..1c2c377 100644 --- a/src/dedup-tranport.ts +++ b/src/dedup-tranport.ts @@ -2,7 +2,6 @@ import Transport from 'winston-transport'; import crypto from 'crypto'; import winston from 'winston'; import './utils'; -import _ from 'lodash'; import { constructLogger } from './logger'; type CacheItem = { @@ -15,6 +14,7 @@ export class WinstonDedup extends Transport { logger: winston.Logger; dedupCache: Map; logRepetitionCount: number; + constructor(options: any) { super(options); this.timeout = options.timeout || 15000; From 98e4aad142e60b2d723fd6728f5c3f3873f51b0e Mon Sep 17 00:00:00 2001 From: Matt Tuusberg Date: Tue, 4 Feb 2025 15:51:19 +0300 Subject: [PATCH 2/3] feat: add shortenNodeName helper function --- src/mediledger.ts | 18 ++++++++++++++++++ test/mediledger.test.ts | 19 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 src/mediledger.ts create mode 100644 test/mediledger.test.ts diff --git a/src/mediledger.ts b/src/mediledger.ts new file mode 100644 index 0000000..7a44885 --- /dev/null +++ b/src/mediledger.ts @@ -0,0 +1,18 @@ +export function shortenNodeName(nodeName: string): string { + if (nodeName.length <= 10) { + return nodeName; + } + + // "baptist-health-system" -> "baptisths" + const parts = nodeName.split('-'); + + // Take the first part as is + let shortened = parts[0]; + + // Concatenate the first letter of each remaining part + for (let i = 1; i < parts.length; i++) { + shortened += parts[i].charAt(0); + } + + return shortened; +} diff --git a/test/mediledger.test.ts b/test/mediledger.test.ts new file mode 100644 index 0000000..9631c62 --- /dev/null +++ b/test/mediledger.test.ts @@ -0,0 +1,19 @@ +import { shortenNodeName } from '../src/medileder'; + +describe('shortenName', () => { + test('returns input as is if length is 10 or less', () => { + expect(shortenNodeName('')).toBe(''); + expect(shortenNodeName('a')).toBe('a'); + expect(shortenNodeName('a-b')).toBe('a-b'); + expect(shortenNodeName('a-be-ce')).toBe('a-be-ce'); + expect(shortenNodeName('1234567890')).toBe('1234567890'); + }); + + test('shortens the input correctly when length is greater than 10', () => { + expect(shortenNodeName('baptist-health-system')).toBe('baptisths'); + expect(shortenNodeName('osf-healthcare')).toBe('osfh'); + expect(shortenNodeName('verylargename-health-system')).toBe( + 'verylargenamehs' + ); + }); +}); From e4ff3575f5c444dea82abde4a6f3d7b358981d06 Mon Sep 17 00:00:00 2001 From: Matt Tuusberg Date: Tue, 4 Feb 2025 15:53:07 +0300 Subject: [PATCH 3/3] fix: correct import path --- test/mediledger.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/mediledger.test.ts b/test/mediledger.test.ts index 9631c62..a866081 100644 --- a/test/mediledger.test.ts +++ b/test/mediledger.test.ts @@ -1,4 +1,4 @@ -import { shortenNodeName } from '../src/medileder'; +import { shortenNodeName } from '../src/mediledger'; describe('shortenName', () => { test('returns input as is if length is 10 or less', () => {