-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathsession-loop-resolver.test.ts
More file actions
297 lines (247 loc) · 10.6 KB
/
session-loop-resolver.test.ts
File metadata and controls
297 lines (247 loc) · 10.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
import { describe, it, expect } from 'bun:test'
import { createSessionLoopResolver } from '../src/services/session-loop-resolver'
describe('createSessionLoopResolver', () => {
const mockLogger = {
log: () => {},
debug: () => {},
error: () => {},
}
describe('direct resolution happy path', () => {
it('returns active loop without consulting parent', async () => {
const getParentSessionId = async () => { throw new Error('should not be called') }
const loopService = {
resolveLoopName: (sessionId: string) => (sessionId === 'session-a' ? 'loop-1' : null),
getActiveState: (name: string) =>
name === 'loop-1' ? { loopName: 'loop-1', active: true, sandbox: true } : null,
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-a')
expect(result).toEqual({ loopName: 'loop-1', active: true, sandbox: true })
})
})
describe('direct not active → parent hop', () => {
it('falls back to parent session when direct loop is not active', async () => {
let parentLookupCalled = false
const getParentSessionId = async (sessionId: string) => {
if (sessionId === 'session-a') {
parentLookupCalled = true
return 'parent-session-1'
}
return null
}
const loopService = {
resolveLoopName: (sessionId: string) => {
if (sessionId === 'session-a') return 'loop-1'
if (sessionId === 'parent-session-1') return 'loop-2'
return null
},
getActiveState: (name: string) => {
if (name === 'loop-1') return { loopName: 'loop-1', active: false, sandbox: true }
if (name === 'loop-2') return { loopName: 'loop-2', active: true, sandbox: true }
return null
},
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-a')
expect(parentLookupCalled).toBe(true)
expect(result).toEqual({ loopName: 'loop-2', active: true, sandbox: true })
})
})
describe('direct not active, no parent', () => {
it('returns null when direct loop is not active and has no parent', async () => {
const getParentSessionId = async () => null
const loopService = {
resolveLoopName: (sessionId: string) => (sessionId === 'session-a' ? 'loop-1' : null),
getActiveState: (name: string) =>
name === 'loop-1' ? { loopName: 'loop-1', active: false, sandbox: true } : null,
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-a')
expect(result).toBeNull()
})
})
describe('direct not active, parent lookup does not cache failures', () => {
it('re-calls getParentSessionId on subsequent invocations for the same session', async () => {
let callCount = 0
const getParentSessionId = async (_sessionId: string) => {
callCount++
return null
}
const loopService = {
resolveLoopName: () => 'loop-1',
getActiveState: () => ({ loopName: 'loop-1', active: false, sandbox: true }),
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
await resolver.resolveActiveLoopForSession('session-a')
await resolver.resolveActiveLoopForSession('session-a')
await resolver.resolveActiveLoopForSession('session-a')
expect(callCount).toBe(3)
})
})
describe('inactive direct loop still consults parent', () => {
it('falls back to parent even when direct loop exists but is inactive', async () => {
let parentLookupCalled = false
const getParentSessionId = async (sessionId: string) => {
if (sessionId === 'session-a') {
parentLookupCalled = true
return 'parent-session-1'
}
return null
}
const loopService = {
resolveLoopName: (sessionId: string) => {
if (sessionId === 'session-a') return 'loop-1'
if (sessionId === 'parent-session-1') return 'loop-2'
return null
},
getActiveState: (name: string) => {
if (name === 'loop-1') return { loopName: 'loop-1', active: false, sandbox: true }
if (name === 'loop-2') return { loopName: 'loop-2', active: true, sandbox: true }
return null
},
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-a')
expect(parentLookupCalled).toBe(true)
expect(result).toEqual({ loopName: 'loop-2', active: true, sandbox: true })
})
})
describe('parent resolves to inactive loop', () => {
it('returns null when parent resolves to inactive loop', async () => {
const getParentSessionId = async (sessionId: string) => {
if (sessionId === 'session-a') return 'parent-session-1'
return null
}
const loopService = {
resolveLoopName: (sessionId: string) => {
if (sessionId === 'session-a') return 'loop-1'
if (sessionId === 'parent-session-1') return 'loop-2'
return null
},
getActiveState: (name: string) => {
if (name === 'loop-1') return { loopName: 'loop-1', active: false, sandbox: true }
if (name === 'loop-2') return { loopName: 'loop-2', active: false, sandbox: true }
return null
},
listActive: () => [],
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-a')
expect(result).toBeNull()
})
})
describe('directory-fallback', () => {
it('resolves child session when directory matches an active loop worktreeDir', async () => {
const getParentSessionId = async (sessionId: string) => sessionId === 'session-subagent' ? 'parent-session' : null
const loopService = {
resolveLoopName: () => null,
getActiveState: (name: string) =>
name === 'active-loop' ? { loopName: 'active-loop', active: true, sandbox: true, worktreeDir: '/worktree' } : null,
listActive: () => [{ loopName: 'active-loop', worktreeDir: '/worktree', sandbox: true, worktree: true, active: true }],
}
const getSessionDirectory = async (_sessionId: string) => '/worktree'
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
getSessionDirectory,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-subagent')
expect(result).toEqual({ loopName: 'active-loop', active: true, sandbox: true, worktreeDir: '/worktree' })
})
it('does not resolve a top-level new session by directory alone', async () => {
const getParentSessionId = async () => null
const loopService = {
resolveLoopName: () => null,
getActiveState: (name: string) =>
name === 'active-loop' ? { loopName: 'active-loop', active: true, sandbox: true, worktreeDir: '/worktree' } : null,
listActive: () => [{ loopName: 'active-loop', worktreeDir: '/worktree', sandbox: true, worktree: true, active: true }],
}
const getSessionDirectory = async (_sessionId: string) => '/worktree'
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
getSessionDirectory,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-new')
expect(result).toBeNull()
})
it('directory-fallback: directory does not match any active loop returns null', async () => {
const getParentSessionId = async () => null
const loopService = {
resolveLoopName: () => null,
getActiveState: (name: string) =>
name === 'active-loop' ? { loopName: 'active-loop', active: true, sandbox: true, worktreeDir: '/worktree' } : null,
listActive: () => [{ loopName: 'active-loop', worktreeDir: '/worktree', sandbox: true, worktree: true, active: true }],
}
const getSessionDirectory = async (_sessionId: string) => '/some-other-dir'
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
getSessionDirectory,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-unknown')
expect(result).toBeNull()
})
it('getSessionDirectory undefined behaves exactly like today', async () => {
const getParentSessionId = async () => null
const loopService = {
resolveLoopName: (sessionId: string) => (sessionId === 'session-a' ? 'loop-1' : null),
getActiveState: (name: string) =>
name === 'loop-1' ? { loopName: 'loop-1', active: false, sandbox: true } : null,
listActive: () => [{ loopName: 'loop-1', worktreeDir: '/worktree', sandbox: true, active: false }],
}
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-a')
expect(result).toBeNull()
})
it('resolves via directory with path normalization', async () => {
const getParentSessionId = async (sessionId: string) => sessionId === 'session-subagent' ? 'parent-session' : null
const loopService = {
resolveLoopName: () => null,
getActiveState: (name: string) =>
name === 'active-loop' ? { loopName: 'active-loop', active: true, sandbox: true, worktreeDir: '/worktree' } : null,
listActive: () => [{ loopName: 'active-loop', worktreeDir: '/worktree/', sandbox: true, worktree: true, active: true }],
}
const getSessionDirectory = async (_sessionId: string) => '/worktree'
const resolver = createSessionLoopResolver({
loop: loopService,
getParentSessionId,
getSessionDirectory,
logger: mockLogger,
})
const result = await resolver.resolveActiveLoopForSession('session-subagent')
expect(result).toEqual({ loopName: 'active-loop', active: true, sandbox: true, worktreeDir: '/worktree' })
})
})
})