-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathplan-approval.test.ts
More file actions
2198 lines (1895 loc) · 70.2 KB
/
plan-approval.test.ts
File metadata and controls
2198 lines (1895 loc) · 70.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import { describe, test, expect, beforeEach, afterEach, vi } from 'vitest'
// Database is resolved via vitest alias to better-sqlite3 at runtime
import { existsSync, mkdirSync, rmSync, writeFileSync, statSync } from 'fs'
import { execSync, spawnSync } from 'child_process'
import { join } from 'path'
// Mock ForgeRpcError for error handling
class MockForgeRpcError extends Error {
constructor(public code: string | undefined, message: string) {
super(message)
}
}
import { createLoopService } from '../src/loop/service'
import { generateUniqueName } from '../src/loop/name-uniqueness'
import { createPlansRepo } from '../src/storage/repos/plans-repo'
import { createLoopsRepo } from '../src/storage/repos/loops-repo'
import { createReviewFindingsRepo } from '../src/storage/repos/review-findings-repo'
import { openForgeDatabase } from '../src/storage/database'
import type { Logger } from '../src/types'
import { createToolExecuteBeforeHook, createToolExecuteAfterHook, createPlanApprovalEventHook } from '../src/hooks/plan-approval'
import type { ToolContext } from '../src/tools/types'
import type { PluginConfig } from '../src/types'
import { tmpdir } from 'os'
import { randomUUID } from 'crypto'
const TEST_DIR = '/tmp/opencode-manager-plan-approval-test-' + Date.now()
function createTestDb(): any {
return openForgeDatabase(join(tmpdir(), `forge-test-${randomUUID()}.db`))
}
function createMockLogger(): Logger {
return {
log: () => {},
error: () => {},
debug: () => {},
}
}
describe('Plan Approval Tool Interception', () => {
let db: any
let loopService: ReturnType<typeof createLoopService>
let plansRepo: ReturnType<typeof createPlansRepo>
const projectId = 'test-project'
const sessionID = 'test-session-123'
const PLAN_APPROVAL_LABELS = ['New session', 'Execute here', 'Loop']
const approvalArgs = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
beforeEach(() => {
db = createTestDb()
const loopsRepo = createLoopsRepo(db)
const reviewFindingsRepo = createReviewFindingsRepo(db)
plansRepo = createPlansRepo(db)
loopService = createLoopService(loopsRepo, plansRepo, reviewFindingsRepo, projectId, createMockLogger())
})
afterEach(() => {
db.close()
})
function simulateToolExecuteAfter(
tool: string,
args: unknown,
output: { title: string; output: string; metadata: unknown },
sessionActive = false
) {
if (sessionActive) {
const loopName = 'test-loop'
const state = {
active: true,
sessionId: sessionID,
loopName,
worktreeDir: '/test/worktree',
worktreeBranch: 'opencode/loop-test',
iteration: 1,
maxIterations: 5,
startedAt: new Date().toISOString(),
prompt: 'Test prompt',
phase: 'coding' as const,
status: 'running' as const,
errorCount: 0,
auditCount: 0,
worktree: true,
currentSectionIndex: 0,
totalSections: 0,
finalAuditDone: false,
}
loopService.setState(loopName, state as any)
}
if (tool === 'question') {
const questionArgs = args as { questions?: Array<{ options?: Array<{ label: string }> }> } | undefined
const options = questionArgs?.questions?.[0]?.options
if (options) {
const labels = options.map((o) => o.label)
const isPlanApproval = PLAN_APPROVAL_LABELS.every((l) => labels.includes(l))
if (isPlanApproval) {
const metadata = output.metadata as { answers?: string[][] } | undefined
const answer = metadata?.answers?.[0]?.[0]?.trim() ?? output.output.trim()
const matchedLabel = PLAN_APPROVAL_LABELS.find((l) => answer === l || answer.startsWith(l))
if (matchedLabel?.toLowerCase() === 'execute here') {
output.output = `${output.output}\n\nSwitching to code agent for execution...`
} else if (matchedLabel) {
// Programmatic dispatch - no directive injection
output.output = `${output.output}\n\n[Programmatic dispatch - no directive]`
} else {
// Custom answer fallback
output.output = `${output.output}\n\n<system-reminder>\nThe user provided a custom response instead of selecting a predefined option. Review their answer and respond accordingly. If they want to proceed with execution, ask the question tool again with one of: "New session", "Execute here", or "Loop". If they want to cancel or revise the plan, help them with that instead.\n</system-reminder>`
}
}
}
return
}
if (!sessionActive) return
const LOOP_BLOCKED_TOOLS: Record<string, string> = {
question: 'The question tool is not available during a loop. Do not ask questions — continue working on the task autonomously.',
loop: 'The loop tool is not available during a loop. Focus on executing the current plan.',
}
if (!(tool in LOOP_BLOCKED_TOOLS)) return
output.title = 'Tool blocked'
output.output = LOOP_BLOCKED_TOOLS[tool]!
}
test('Detects plan approval question and handles "New session" programmatically', () => {
const output = { title: '', output: 'New session', metadata: {} }
simulateToolExecuteAfter('question', approvalArgs, output)
expect(output.output).toContain('New session')
expect(output.output).not.toContain('<system-reminder>')
})
test('Detects plan approval question and handles "Execute here" with abort', () => {
const output = { title: '', output: 'Execute here', metadata: {} }
simulateToolExecuteAfter('question', approvalArgs, output)
expect(output.output).toContain('Execute here')
expect(output.output).toContain('Switching to code agent')
expect(output.output).not.toContain('<system-reminder>')
})
test('Detects plan approval question and handles "Loop" programmatically', () => {
const output = { title: '', output: 'Loop', metadata: {} }
simulateToolExecuteAfter('question', approvalArgs, output)
expect(output.output).toContain('Loop')
expect(output.output).not.toContain('<system-reminder>')
expect(output.output).not.toContain('memory-loop')
})
test('Injects directive for unknown answer', () => {
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = { title: '', output: 'Custom answer', metadata: {} }
simulateToolExecuteAfter('question', args, output)
expect(output.output).toContain('Custom answer')
expect(output.output).toContain('<system-reminder>')
expect(output.output).toContain('custom response')
expect(output.output).toContain('respond accordingly')
})
test('Matches partial answer that starts with label', () => {
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = { title: '', output: 'New session (with custom config)', metadata: {} }
simulateToolExecuteAfter('question', args, output)
expect(output.output).toContain('New session (with custom config)')
expect(output.output).not.toContain('<system-reminder>')
})
test('Does not match partial label in middle of text', () => {
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = { title: '', output: 'I want to create a session', metadata: {} }
simulateToolExecuteAfter('question', args, output)
expect(output.output).toContain('I want to create a session')
expect(output.output).toContain('<system-reminder>')
expect(output.output).toContain('custom response')
})
test('Does not modify non-approval questions', () => {
const args = {
questions: [{
question: 'What is your preference?',
options: [
{ label: 'Option A', description: 'First option' },
{ label: 'Option B', description: 'Second option' },
],
}],
}
const output = { title: '', output: 'Option A', metadata: {} }
const originalOutput = output.output
simulateToolExecuteAfter('question', args, output)
expect(output.output).toBe(originalOutput)
expect(output.output).not.toContain('<system-reminder>')
})
test('Does not modify non-question tools', () => {
const output = { title: '', output: 'Some result', metadata: {} }
const originalOutput = output.output
simulateToolExecuteAfter('plan-read', {}, output)
expect(output.output).toBe(originalOutput)
expect(output.output).not.toContain('<system-reminder>')
})
test('Does not treat pre-plan approval question as execution approval', () => {
const args = {
questions: [{
question: 'Should I write the implementation plan?',
options: [
{ label: 'Yes', description: 'Write the plan' },
{ label: 'No', description: 'Not yet' },
],
}],
}
const output = { title: '', output: 'Yes', metadata: {} }
const originalOutput = output.output
simulateToolExecuteAfter('question', args, output)
expect(output.output).toBe(originalOutput)
expect(output.output).not.toContain('<system-reminder>')
expect(output.output).not.toContain('Switching to code agent')
})
test('Loop blocking still works for question tool when loop is active', () => {
const output = { title: '', output: 'test', metadata: {} }
simulateToolExecuteAfter('question', {}, output, true)
expect(output.title).toBe('')
expect(output.output).toBe('test')
})
test('Loop blocking works for loop tool', () => {
const output = { title: '', output: 'test', metadata: {} }
simulateToolExecuteAfter('loop', {}, output, true)
expect(output.title).toBe('Tool blocked')
expect(output.output).toContain('loop tool is not available')
})
test('Loop blocking does not affect non-blocked tools', () => {
const output = { title: '', output: 'test', metadata: {} }
simulateToolExecuteAfter('plan-read', {}, output, true)
expect(output.title).toBe('')
expect(output.output).toBe('test')
})
test('Loop blocking only applies when loop is active', () => {
const output = { title: '', output: 'test', metadata: {} }
simulateToolExecuteAfter('loop', {}, output, false)
expect(output.title).toBe('')
expect(output.output).toBe('test')
})
test('Matches metadata answer exactly', async () => {
const v2AbortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const legacyAbortSpy = vi.fn(() => Promise.resolve({ data: {} } as any))
const ctx = {
loopService: {
resolveLoopName: () => 'test-loop',
getActiveState: () => null,
},
logger: createMockLogger(),
v2: {
session: {
abort: v2AbortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: {
messages: [],
systemPrompt: '',
client: {
session: {
abort: legacyAbortSpy,
create: async () => ({ data: { id: 'new-session-id' } }),
promptAsync: async () => ({ data: {} }),
},
} as any,
},
systemPrompt: '',
messages: [],
loopsRepo: createLoopsRepo(db),
reviewFindingsRepo: createReviewFindingsRepo(db),
sandboxManager: null,
} as unknown as ToolContext
// Write a plan for the session so resolveCurrentSessionPlan succeeds
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'Execute here',
metadata: { answers: [['Execute here']] },
}
await expect(hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)).resolves.toBeUndefined()
expect(output.output).toBe('Execute here')
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(legacyAbortSpy).toHaveBeenCalled()
})
test('Matches metadata answer by prefix', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const ctx = {
loopService: {
resolveLoopName: () => 'test-loop',
getActiveState: () => null,
},
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '' },
systemPrompt: '',
messages: [],
loopsRepo: createLoopsRepo(db),
reviewFindingsRepo: createReviewFindingsRepo(db),
sandboxManager: null,
} as unknown as ToolContext
// Write a plan for the session so resolveCurrentSessionPlan succeeds
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'User has answered your questions: ...',
metadata: { answers: [['New session (Recommended)']] },
}
await expect(hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)).resolves.toBeUndefined()
expect(output.output).toBe('User has answered your questions: ...')
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(abortSpy).toHaveBeenCalledWith({ sessionID, directory: "/test" })
})
test('Does not match middle-of-string text', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const ctx = {
loopService: {
resolveLoopName: () => 'test-loop',
getActiveState: () => null,
},
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '' },
systemPrompt: '',
messages: [],
loopsRepo: createLoopsRepo(db),
reviewFindingsRepo: createReviewFindingsRepo(db),
sandboxManager: null,
} as unknown as ToolContext
// Write a plan for the session so resolveCurrentSessionPlan succeeds
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'User has answered your questions: ...',
metadata: { answers: [['Please use New session']] },
}
await hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)
expect(output.output).toContain('<system-reminder>')
expect(abortSpy).not.toHaveBeenCalled()
})
test('Falls back to output when metadata answers are missing', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const ctx = {
loopService: {
resolveLoopName: () => 'test-loop',
getActiveState: () => null,
},
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '' },
systemPrompt: '',
messages: [],
loopsRepo: createLoopsRepo(db),
reviewFindingsRepo: createReviewFindingsRepo(db),
sandboxManager: null,
} as unknown as ToolContext
// Write a plan for the session so resolveCurrentSessionPlan succeeds
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'New session',
metadata: {},
}
await expect(hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)).resolves.toBeUndefined()
expect(output.output).toContain('New session')
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(abortSpy).toHaveBeenCalledWith({ sessionID, directory: "/test" })
})
test('Execute here approval schedules source abort and returns without throwing', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const ctx = {
loopService: {
resolveLoopName: () => 'test-loop',
getActiveState: () => null,
},
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '' },
systemPrompt: '',
messages: [],
loopsRepo: createLoopsRepo(db),
reviewFindingsRepo: createReviewFindingsRepo(db),
sandboxManager: null,
} as unknown as ToolContext
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'Execute here',
metadata: { answers: [['Execute here']] },
}
await expect(hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)).resolves.toBeUndefined()
expect(output.output).toBe('Execute here')
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(abortSpy).toHaveBeenCalledWith({ sessionID, directory: "/test" })
})
test('New session approval schedules source abort and returns without throwing', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const ctx = {
loopService: {
resolveLoopName: () => 'test-loop',
getActiveState: () => null,
},
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '' },
systemPrompt: '',
messages: [],
loopsRepo: createLoopsRepo(db),
reviewFindingsRepo: createReviewFindingsRepo(db),
sandboxManager: null,
} as unknown as ToolContext
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'New session',
metadata: { answers: [['New session']] },
}
await expect(hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)).resolves.toBeUndefined()
expect(output.output).toContain('New session')
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(abortSpy).toHaveBeenCalledWith({ sessionID, directory: "/test" })
})
test('Loop approval schedules source abort and returns without throwing', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const loopsRepo = createLoopsRepo(db)
const reviewFindingsRepo = createReviewFindingsRepo(db)
const loopService = createLoopService(loopsRepo, plansRepo, reviewFindingsRepo, projectId, createMockLogger())
const ctx = {
loopService,
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '', client: { session: { promptAsync: async () => ({ data: {} }) } } as any },
systemPrompt: '',
messages: [],
loopsRepo,
reviewFindingsRepo,
sandboxManager: null,
} as unknown as ToolContext
plansRepo.writeForSession(projectId, sessionID, '# Test Plan\n\nThis is a test plan.')
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'Loop',
metadata: { answers: [['Loop']] },
}
await expect(hook(
{ tool: 'question', sessionID, callID: 'test-call', args },
output
)).resolves.toBeUndefined()
expect(output.output).toBe('Loop')
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(abortSpy).toHaveBeenCalledWith({ sessionID, directory: "/test" })
})
test('dispatches loop.start without a mode field when Loop is selected', async () => {
const abortSpy = vi.fn(() => Promise.resolve({ data: {} }))
const loopsRepo = createLoopsRepo(db)
const reviewFindingsRepo = createReviewFindingsRepo(db)
const loopService = createLoopService(loopsRepo, plansRepo, reviewFindingsRepo, projectId, createMockLogger())
const uniqueSessionId = `loop-dispatch-${Date.now()}`
const ctx = {
loopService,
logger: createMockLogger(),
v2: {
session: {
abort: abortSpy,
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2'],
plansRepo,
config: {} as PluginConfig,
projectId,
directory: '/test-dispatch',
dataDir: TEST_DIR,
cleanup: async () => {},
input: { messages: [], systemPrompt: '', client: { session: { promptAsync: async () => ({ data: {} }) } } as any },
systemPrompt: '',
messages: [],
loopsRepo,
reviewFindingsRepo,
sandboxManager: null,
} as unknown as ToolContext
plansRepo.writeForSession(projectId, uniqueSessionId, '# Dispatch Test Plan\n\nUnique plan for dispatch test.')
const executionModule = await import('../src/services/execution')
let capturedCommand: any = null
vi.spyOn(executionModule, 'createForgeExecutionService').mockImplementation((deps: any) => ({
dispatch: async (_execCtx: any, command: any) => {
capturedCommand = command
return { ok: true, data: {} }
},
}))
try {
const hook = createToolExecuteAfterHook(ctx)
const args = {
questions: [{
question: 'How would you like to proceed?',
options: [
{ label: 'New session', description: 'Create new session' },
{ label: 'Execute here', description: 'Execute here' },
{ label: 'Loop', description: 'Loop' },
],
}],
}
const output = {
title: 'Asked 1 question',
output: 'Loop',
metadata: { answers: [['Loop']] },
}
await expect(hook(
{ tool: 'question', sessionID: uniqueSessionId, callID: 'dispatch-test-call', args },
output
)).resolves.toBeUndefined()
// The scheduled dispatch fires synchronously before the first await in the IIFE.
// Since our mock service.dispatch resolves immediately, the task completes within one microtask.
await new Promise(resolve => setTimeout(resolve, 10))
expect((output.metadata as any).forgePlanApprovalHandled).toBe(true)
expect(abortSpy).toHaveBeenCalled()
expect(capturedCommand).toBeDefined()
expect(capturedCommand.type).toBe('loop.start')
expect(capturedCommand).not.toHaveProperty('mode')
} finally {
vi.restoreAllMocks()
}
})
})
describe('Tool blocking hook', () => {
const sessionID = 'outside-session'
const loopSessionID = 'loop-session'
const loopName = 'active-loop'
function createContextForLoopState(state: { active: boolean; sessionId: string; phase?: string } | null): ToolContext {
return {
loopService: {
resolveLoopName: () => state ? loopName : null,
getActiveState: () => state,
},
logger: createMockLogger(),
} as unknown as ToolContext
}
test('does not block question when resolved loop belongs to another session', async () => {
const hook = createToolExecuteBeforeHook(createContextForLoopState({
active: true,
sessionId: loopSessionID,
phase: 'auditing',
}))!
await expect(hook({ tool: 'question', sessionID, callID: 'call-1' }, { args: {} })).resolves.toBeUndefined()
})
test('blocks question for active loop session', async () => {
const hook = createToolExecuteBeforeHook(createContextForLoopState({
active: true,
sessionId: loopSessionID,
phase: 'auditing',
}))!
await expect(hook({ tool: 'question', sessionID: loopSessionID, callID: 'call-1' }, { args: {} })).rejects.toThrow('question tool is not available')
})
test('blocks question for active audit session', async () => {
const hook = createToolExecuteBeforeHook(createContextForLoopState({
active: true,
sessionId: loopSessionID,
phase: 'auditing',
}))!
await expect(hook({ tool: 'question', sessionID: loopSessionID, callID: 'call-1' }, { args: {} })).rejects.toThrow('question tool is not available')
})
test('blocks question for child sessions resolved into an active loop', async () => {
const hook = createToolExecuteBeforeHook(createContextForLoopState(null), {
resolveActiveLoopForSession: async (sessionID) => sessionID === 'child-session'
? { active: true, loopName, phase: 'auditing' }
: null,
})!
await expect(hook({ tool: 'question', sessionID: 'child-session', callID: 'call-1' }, { args: {} })).rejects.toThrow('question tool is not available')
})
test('rewrites blocked question output for child sessions resolved into an active loop', async () => {
const hook = createToolExecuteAfterHook(createContextForLoopState(null), {
resolveActiveLoopForSession: async (sessionID) => sessionID === 'child-session'
? { active: true, loopName, phase: 'auditing' }
: null,
})!
const output = { title: '', output: 'original output', metadata: {} }
await hook({ tool: 'question', sessionID: 'child-session', callID: 'call-1', args: {} }, output)
expect(output.title).toBe('Tool blocked')
expect(output.output).toContain('question tool is not available')
})
test('does not rewrite after-hook output when resolved loop belongs to another session', async () => {
const hook = createToolExecuteAfterHook(createContextForLoopState({
active: true,
sessionId: loopSessionID,
phase: 'auditing',
}))!
const output = { title: '', output: 'original output', metadata: {} }
await hook({ tool: 'loop', sessionID, callID: 'call-1', args: {} }, output)
expect(output.title).toBe('')
expect(output.output).toBe('original output')
})
})
describe('Execute here bypass', () => {
const projectId = 'test-project'
const sessionID = 'test-session-456'
const testDir = '/test/dir'
const openDbs: any[] = []
afterEach(() => {
for (const db of openDbs) db.close()
openDbs.length = 0
})
function createMockContext(overrides?: Partial<ToolContext>): ToolContext {
const mockV2 = {
session: {
abort: async () => ({ data: {} }),
promptAsync: async () => ({ data: {} }),
create: async () => ({ data: { id: 'new-session-id' } }),
},
tui: {
selectSession: async () => ({ data: {} }),
publish: async () => ({ data: {} }),
},
} as unknown as ToolContext['v2']
const mockConfig = {
executionModel: 'test-provider/test-model',
} as PluginConfig
const mockLogger = createMockLogger()
const db = createTestDb()
openDbs.push(db)
const loopsRepo = createLoopsRepo(db)
const reviewFindingsRepo = createReviewFindingsRepo(db)
const plansRepo = createPlansRepo(db)
const loopService = createLoopService(loopsRepo, plansRepo, reviewFindingsRepo, projectId, mockLogger)
return {
projectId,
directory: testDir,
config: mockConfig,
logger: mockLogger,
db,
loopService,
plansRepo,
loopsRepo,
reviewFindingsRepo,
v2: mockV2,
input: { messages: [], systemPrompt: '', client: { session: { promptAsync: async () => ({ data: {} }) } } as any },
...overrides,