fix(app): terminal issues

adamdotdevin · adamdotdevin · commit e70d2b27de3a · 2026-02-22T06:17:59.000-06:00
diff --git a/packages/opencode/src/pty/index.ts b/packages/opencode/src/pty/index.ts
@@ -39,8 +39,9 @@ export namespace Pty {
     return next
   }
 
-  const token = (ws: Socket) => {
-    const data = ws.data
+  const token = (ws: unknown) => {
+    if (!ws || typeof ws !== "object") return ws
+    const data = (ws as { data?: unknown }).data
     if (data === undefined) return
     if (data === null) return
     if (typeof data !== "object") return data
@@ -317,7 +318,7 @@ export namespace Pty {
     }
   }
 
-  export function connect(id: string, ws: Socket, cursor?: number) {
+  export function connect(id: string, ws: Socket, cursor?: number, identity?: unknown) {
     const session = state().get(id)
     if (!session) {
       ws.close()
@@ -337,7 +338,7 @@ export namespace Pty {
     }
 
     owners.set(ws, id)
-    session.subscribers.set(ws, { id: socketId, token: token(ws) })
+    session.subscribers.set(ws, { id: socketId, token: token(identity ?? ws) })
 
     const cleanup = () => {
       session.subscribers.delete(ws)
diff --git a/packages/opencode/src/server/routes/pty.ts b/packages/opencode/src/server/routes/pty.ts
@@ -182,7 +182,7 @@ export const PtyRoutes = lazy(() =>
               ws.close()
               return
             }
-            handler = Pty.connect(id, socket, cursor)
+            handler = Pty.connect(id, socket, cursor, ws)
           },
           onMessage(event) {
             if (typeof event.data !== "string") return
diff --git a/packages/opencode/test/pty/pty-output-isolation.test.ts b/packages/opencode/test/pty/pty-output-isolation.test.ts
@@ -98,6 +98,54 @@ describe("pty", () => {
     })
   })
 
+  test("does not leak when identity token is only on websocket wrapper", async () => {
+    await using dir = await tmpdir({ git: true })
+
+    await Instance.provide({
+      directory: dir.path,
+      fn: async () => {
+        const a = await Pty.create({ command: "cat", title: "a" })
+        try {
+          const outA: string[] = []
+          const outB: string[] = []
+          const text = (data: string | Uint8Array | ArrayBuffer) => {
+            if (typeof data === "string") return data
+            if (data instanceof ArrayBuffer) return Buffer.from(new Uint8Array(data)).toString("utf8")
+            return Buffer.from(data).toString("utf8")
+          }
+
+          const raw: Parameters<typeof Pty.connect>[1] = {
+            readyState: 1,
+            send: (data) => {
+              outA.push(text(data))
+            },
+            close: () => {
+              // no-op
+            },
+          }
+
+          const wrap = { data: { events: { connection: "a" } } }
+
+          Pty.connect(a.id, raw, undefined, wrap)
+          outA.length = 0
+
+          // Simulate Bun reusing the raw socket object before the next onOpen,
+          // while the connection token only exists on the wrapper socket.
+          raw.send = (data) => {
+            outB.push(text(data))
+          }
+
+          Pty.write(a.id, "AAA\n")
+          await Bun.sleep(100)
+
+          expect(outB.join("")).not.toContain("AAA")
+        } finally {
+          await Pty.remove(a.id)
+        }
+      },
+    })
+  })
+
   test("does not leak output when socket data mutates in-place", async () => {
     await using dir = await tmpdir({ git: true })
 

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,9 @@ export namespace Pty {`
`39`	`39`	`return next`
`40`	`40`	`}`
`41`	`41`
`42`		`- const token = (ws: Socket) => {`
`43`		`- const data = ws.data`
	`42`	`+ const token = (ws: unknown) => {`
	`43`	`+ if (!ws \|\| typeof ws !== "object") return ws`
	`44`	`+ const data = (ws as { data?: unknown }).data`
`44`	`45`	`if (data === undefined) return`
`45`	`46`	`if (data === null) return`
`46`	`47`	`if (typeof data !== "object") return data`
`@@ -317,7 +318,7 @@ export namespace Pty {`
`317`	`318`	`}`
`318`	`319`	`}`
`319`	`320`
`320`		`- export function connect(id: string, ws: Socket, cursor?: number) {`
	`321`	`+ export function connect(id: string, ws: Socket, cursor?: number, identity?: unknown) {`
`321`	`322`	`const session = state().get(id)`
`322`	`323`	`if (!session) {`
`323`	`324`	`ws.close()`
`@@ -337,7 +338,7 @@ export namespace Pty {`
`337`	`338`	`}`
`338`	`339`
`339`	`340`	`owners.set(ws, id)`
`340`		`- session.subscribers.set(ws, { id: socketId, token: token(ws) })`
	`341`	`+ session.subscribers.set(ws, { id: socketId, token: token(identity ?? ws) })`
`341`	`342`
`342`	`343`	`const cleanup = () => {`
`343`	`344`	`session.subscribers.delete(ws)`
Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ export const PtyRoutes = lazy(() =>`
`182`	`182`	`ws.close()`
`183`	`183`	`return`
`184`	`184`	`}`
`185`		`- handler = Pty.connect(id, socket, cursor)`
	`185`	`+ handler = Pty.connect(id, socket, cursor, ws)`
`186`	`186`	`},`
`187`	`187`	`onMessage(event) {`
`188`	`188`	`if (typeof event.data !== "string") return`