Removed artifact signing and made inner classes static, as suggested by

Christian Huff · Christian Huff · commit 09b1a984a315 · 2013-03-12T09:38:07.000+01:00
findbugs
diff --git a/pom.xml b/pom.xml
@@ -66,15 +66,15 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-gpg-plugin</artifactId>
         <version>1.4</version>
-        <executions>
+        <!-- executions>
           <execution>
             <id>sign-artifacts</id>
             <phase>verify</phase>
             <goals>
               <goal>sign</goal>
             </goals>
           </execution>
-        </executions>
+        </executions-->
       </plugin>
         <plugin>
         <groupId>org.codehaus.mojo</groupId>
diff --git a/src/main/java/org/scribe/builder/api/FacebookApi.java b/src/main/java/org/scribe/builder/api/FacebookApi.java
@@ -14,7 +14,7 @@ public class FacebookApi extends DefaultApi20 {
   private static final String AUTHORIZE_URL        = "https://www.facebook.com/dialog/oauth?client_id=%s&redirect_uri=%s";
   private static final String SCOPED_AUTHORIZE_URL = AUTHORIZE_URL + "&scope=%s";
 
-  private class FacebookTokenExtractor extends TokenExtractor20Impl {
+  private static class FacebookTokenExtractor extends TokenExtractor20Impl {
 
     private static final String TOKEN_REGEX = "expires=([0-9]+)";
 
diff --git a/src/main/java/org/scribe/builder/api/GoogleApi20.java b/src/main/java/org/scribe/builder/api/GoogleApi20.java
@@ -87,7 +87,7 @@ public OAuthService createService(OAuthConfig config) {
     return new GoogleOAuth2Service(this, config);
   }
 
-  private class GoogleOAuth2Service extends OAuth20ServiceImpl {
+  private static class GoogleOAuth2Service extends OAuth20ServiceImpl {
 
     private static final String GRANT_TYPE_AUTHORIZATION_CODE = "authorization_code";
     private static final String GRANT_TYPE                    = "grant_type";

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public OAuthService createService(OAuthConfig config) {`
`87`	`87`	`return new GoogleOAuth2Service(this, config);`
`88`	`88`	`}`
`89`	`89`
`90`		`- private class GoogleOAuth2Service extends OAuth20ServiceImpl {`
	`90`	`+ private static class GoogleOAuth2Service extends OAuth20ServiceImpl {`
`91`	`91`
`92`	`92`	`private static final String GRANT_TYPE_AUTHORIZATION_CODE = "authorization_code";`
`93`	`93`	`private static final String GRANT_TYPE = "grant_type";`