cleanup interfaces

gfx · gfx · commit 9825173b0cda · 2020-09-06T15:12:17.000+09:00
diff --git a/src/Decoder.ts b/src/Decoder.ts
@@ -91,7 +91,7 @@ export class Decoder<ContextType> {
     this.pos = 0;
   }
 
-  public appendBuffer(buffer: ArrayLike<number>) {
+  private appendBuffer(buffer: ArrayLike<number>) {
     if (this.headByte === HEAD_BYTE_REQUIRED && !this.hasRemaining()) {
       this.setBuffer(buffer);
     } else {
@@ -114,11 +114,7 @@ export class Decoder<ContextType> {
     return new RangeError(`Extra ${view.byteLength - pos} of ${view.byteLength} byte(s) found at buffer[${posToShow}]`);
   }
 
-  /**
-   * A synchronous interface to decode a byte buffer. It mutates the decoder instance.
-   * @param buffer A byte buffer encoded in MessagePack.
-   */
-  public decodeSync(buffer: ArrayLike<number> | ArrayBuffer): unknown {
+  public decode(buffer: ArrayLike<number> | ArrayBuffer): unknown {
     this.reinitializeState();
     this.setBuffer(buffer);
     return this.doDecodeSingleSync();
diff --git a/src/Encoder.ts b/src/Encoder.ts
@@ -22,7 +22,7 @@ export class Encoder<ContextType> {
     private readonly ignoreUndefined = false,
   ) {}
 
-  public getUint8Array(): Uint8Array {
+  private getUint8Array(): Uint8Array {
     return this.bytes.subarray(0, this.pos);
   }
 
diff --git a/src/decode.ts b/src/decode.ts
@@ -55,5 +55,5 @@ export function decode<ContextType>(
     options.maxMapLength,
     options.maxExtLength,
   );
-  return decoder.decodeSync(buffer);
+  return decoder.decode(buffer);
 }
diff --git a/test/reuse-instances.test.ts b/test/reuse-instances.test.ts
@@ -25,7 +25,7 @@ describe("shared instances", () => {
       };
 
       const encoded: Uint8Array = encoder.encode(object);
-      deepStrictEqual(decoder.decodeSync(encoded), object);
+      deepStrictEqual(decoder.decode(encoded), object);
     });
 
     it("runs #2", () => {
@@ -41,7 +41,7 @@ describe("shared instances", () => {
       };
 
       const encoded: Uint8Array = encoder.encode(object);
-      deepStrictEqual(decoder.decodeSync(encoded), object);
+      deepStrictEqual(decoder.decode(encoded), object);
     });
   });
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export class Encoder<ContextType> {`
`22`	`22`	`private readonly ignoreUndefined = false,`
`23`	`23`	`) {}`
`24`	`24`
`25`		`- public getUint8Array(): Uint8Array {`
	`25`	`+ private getUint8Array(): Uint8Array {`
`26`	`26`	`return this.bytes.subarray(0, this.pos);`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -55,5 +55,5 @@ export function decode<ContextType>(`
`55`	`55`	`options.maxMapLength,`
`56`	`56`	`options.maxExtLength,`
`57`	`57`	`);`
`58`		`- return decoder.decodeSync(buffer);`
	`58`	`+ return decoder.decode(buffer);`
`59`	`59`	`}`