tools: enable no-throw-literal ESLint rule

Trott · Trott · commit 433465863527 · 2017-02-07T14:17:52.000-08:00
Only throw the Error object itself or an object using the Error object as base objects for user-defined exceptions. PR-URL: nodejs#11168 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -40,6 +40,7 @@ rules:
   no-octal: 2
   no-redeclare: 2
   no-self-assign: 2
+  no-throw-literal: 2
   no-unused-labels: 2
   no-useless-call: 2
   no-useless-escape: 2
diff --git a/test/message/throw_custom_error.js b/test/message/throw_custom_error.js
@@ -2,4 +2,5 @@
 require('../common');
 
 // custom error throwing
+// eslint-disable-next-line no-throw-literal
 throw ({ name: 'MyCustomError', message: 'This is a custom message' });
diff --git a/test/message/throw_custom_error.out b/test/message/throw_custom_error.out
@@ -1,4 +1,4 @@
-*test*message*throw_custom_error.js:5
+*test*message*throw_custom_error.js:6
 throw ({ name: 'MyCustomError', message: 'This is a custom message' });
 ^
 MyCustomError: This is a custom message
diff --git a/test/message/throw_in_line_with_tabs.js b/test/message/throw_in_line_with_tabs.js
@@ -6,6 +6,7 @@ console.error('before');
 
 (function() {
 	// these lines should contain tab!
+	// eslint-disable-next-line no-throw-literal
 	throw ({ foo: 'bar' });
 })();
 
diff --git a/test/message/throw_in_line_with_tabs.out b/test/message/throw_in_line_with_tabs.out
@@ -1,5 +1,5 @@
 before
-*test*message*throw_in_line_with_tabs.js:9
+*test*message*throw_in_line_with_tabs.js:10
 	throw ({ foo: 'bar' });
 	^
 [object Object]
diff --git a/test/message/throw_non_error.js b/test/message/throw_non_error.js
@@ -2,4 +2,5 @@
 require('../common');
 
 // custom error throwing
+// eslint-disable-next-line no-throw-literal
 throw ({ foo: 'bar' });
diff --git a/test/message/throw_non_error.out b/test/message/throw_non_error.out
@@ -1,4 +1,4 @@
-*test*message*throw_non_error.js:5
+*test*message*throw_non_error.js:6
 throw ({ foo: 'bar' });
 ^
 [object Object]
diff --git a/test/message/throw_null.js b/test/message/throw_null.js
@@ -1,4 +1,5 @@
 'use strict';
 require('../common');
 
+// eslint-disable-next-line no-throw-literal
 throw null;
diff --git a/test/message/throw_null.out b/test/message/throw_null.out
@@ -1,5 +1,5 @@
 
-*test*message*throw_null.js:4
+*test*message*throw_null.js:5
 throw null;
 ^
 null
diff --git a/test/message/throw_undefined.js b/test/message/throw_undefined.js
@@ -1,4 +1,5 @@
 'use strict';
 require('../common');
 
+// eslint-disable-next-line no-throw-literal
 throw undefined;
diff --git a/test/message/throw_undefined.out b/test/message/throw_undefined.out
@@ -1,5 +1,5 @@
 
-*test*message*throw_undefined.js:4
+*test*message*throw_undefined.js:5
 throw undefined;
 ^
 undefined
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -394,7 +394,7 @@ threw = false;
 try {
   assert.throws(
       function() {
-        throw ({});
+        throw ({}); // eslint-disable-line no-throw-literal
       },
       Array
   );
@@ -576,6 +576,7 @@ testBlockTypeError(assert.throws, undefined);
 testBlockTypeError(assert.doesNotThrow, undefined);
 
 // https://github.com/nodejs/node/issues/3275
+// eslint-disable-next-line no-throw-literal
 assert.throws(() => { throw 'error'; }, (err) => err === 'error');
 assert.throws(() => { throw new Error(); }, (err) => err instanceof Error);
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-testmessage*throw_custom_error.js:5`
	`1`	`+testmessage*throw_custom_error.js:6`
`2`	`2`	`throw ({ name: 'MyCustomError', message: 'This is a custom message' });`
`3`	`3`	`^`
`4`	`4`	`MyCustomError: This is a custom message`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`before`
`2`		`-testmessage*throw_in_line_with_tabs.js:9`
	`2`	`+testmessage*throw_in_line_with_tabs.js:10`
`3`	`3`	`throw ({ foo: 'bar' });`
`4`	`4`	`^`
`5`	`5`	`[object Object]`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-testmessage*throw_non_error.js:5`
	`1`	`+testmessage*throw_non_error.js:6`
`2`	`2`	`throw ({ foo: 'bar' });`
`3`	`3`	`^`
`4`	`4`	`[object Object]`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`
`2`		`-testmessage*throw_null.js:4`
	`2`	`+testmessage*throw_null.js:5`
`3`	`3`	`throw null;`
`4`	`4`	`^`
`5`	`5`	`null`