Skip to content

Commit b1e8a73

Browse files
Tahanimaromani
Tahanima
authored and
romani
committed
Issue #13213: Remove '//ok' comments for emptylineseparator module
1 parent 8dffb48 commit b1e8a73

23 files changed

Lines changed: 85 additions & 199 deletions

‎config/checkstyle-input-suppressions.xml‎

Lines changed: 0 additions & 114 deletions
Original file line numberDiff line numberDiff line change
@@ -101,116 +101,6 @@
101101
files="checks[\\/]whitespace[\\/]emptyforiteratorpad[\\/]InputEmptyForIteratorPadToCheckTrimFunctionInOptionProperty.java"/>
102102
<suppress id="UnnecessaryOkComment"
103103
files="checks[\\/]whitespace[\\/]emptyforiteratorpad[\\/]InputEmptyForIteratorPadToCheckUppercaseFunctionInOptionProperty.java"/>
104-
<suppress id="UnnecessaryOkComment"
105-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorBlockCommentSeparatedFromPackage.java"/>
106-
<suppress id="UnnecessaryOkComment"
107-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorEmptyLineAfterPackageForImportAst.java"/>
108-
<suppress id="UnnecessaryOkComment"
109-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorEnumMembers.java"/>
110-
<suppress id="UnnecessaryOkComment"
111-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorFormerException.java"/>
112-
<suppress id="UnnecessaryOkComment"
113-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorImportSeparatedFromPackage.java"/>
114-
<suppress id="UnnecessaryOkComment"
115-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorImports.java"/>
116-
<suppress id="UnnecessaryOkComment"
117-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorInterfaceFields.java"/>
118-
<suppress id="UnnecessaryOkComment"
119-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorInterfaceFields.java"/>
120-
<suppress id="UnnecessaryOkComment"
121-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorInterfaceFields.java"/>
122-
<suppress id="UnnecessaryOkComment"
123-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorInterfaceFields.java"/>
124-
<suppress id="UnnecessaryOkComment"
125-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorMultipleFieldsInClass.java"/>
126-
<suppress id="UnnecessaryOkComment"
127-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorMultipleLines.java"/>
128-
<suppress id="UnnecessaryOkComment"
129-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorMultipleLines.java"/>
130-
<suppress id="UnnecessaryOkComment"
131-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNewMethodDef.java"/>
132-
<suppress id="UnnecessaryOkComment"
133-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
134-
<suppress id="UnnecessaryOkComment"
135-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
136-
<suppress id="UnnecessaryOkComment"
137-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
138-
<suppress id="UnnecessaryOkComment"
139-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
140-
<suppress id="UnnecessaryOkComment"
141-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
142-
<suppress id="UnnecessaryOkComment"
143-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
144-
<suppress id="UnnecessaryOkComment"
145-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorNoViolationOnEmptyLineBeforeComments.java"/>
146-
<suppress id="UnnecessaryOkComment"
147-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorPrePreviousLineEmptiness.java"/>
148-
<suppress id="UnnecessaryOkComment"
149-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorPrePreviousLineIsEmpty.java"/>
150-
<suppress id="UnnecessaryOkComment"
151-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorPreviousLineEmptiness.java"/>
152-
<suppress id="UnnecessaryOkComment"
153-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorSingleCommentSeparatedFromPackage.java"/>
154-
<suppress id="UnnecessaryOkComment"
155-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorSingleCommentSeparatedFromPackage.java"/>
156-
<suppress id="UnnecessaryOkComment"
157-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorSingleTypeVariables.java"/>
158-
<suppress id="UnnecessaryOkComment"
159-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorSingleTypeVariables.java"/>
160-
<suppress id="UnnecessaryOkComment"
161-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorSingleTypeVariables.java"/>
162-
<suppress id="UnnecessaryOkComment"
163-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorSingleTypeVariables.java"/>
164-
<suppress id="UnnecessaryOkComment"
165-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
166-
<suppress id="UnnecessaryOkComment"
167-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
168-
<suppress id="UnnecessaryOkComment"
169-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
170-
<suppress id="UnnecessaryOkComment"
171-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
172-
<suppress id="UnnecessaryOkComment"
173-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
174-
<suppress id="UnnecessaryOkComment"
175-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
176-
<suppress id="UnnecessaryOkComment"
177-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
178-
<suppress id="UnnecessaryOkComment"
179-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
180-
<suppress id="UnnecessaryOkComment"
181-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
182-
<suppress id="UnnecessaryOkComment"
183-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
184-
<suppress id="UnnecessaryOkComment"
185-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
186-
<suppress id="UnnecessaryOkComment"
187-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
188-
<suppress id="UnnecessaryOkComment"
189-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
190-
<suppress id="UnnecessaryOkComment"
191-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
192-
<suppress id="UnnecessaryOkComment"
193-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
194-
<suppress id="UnnecessaryOkComment"
195-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
196-
<suppress id="UnnecessaryOkComment"
197-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
198-
<suppress id="UnnecessaryOkComment"
199-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
200-
<suppress id="UnnecessaryOkComment"
201-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
202-
<suppress id="UnnecessaryOkComment"
203-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
204-
<suppress id="UnnecessaryOkComment"
205-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithComments2.java"/>
206-
<suppress id="UnnecessaryOkComment"
207-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithEmoji.java"/>
208-
<suppress id="UnnecessaryOkComment"
209-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparatorWithEmoji.java"/>
210-
<suppress id="UnnecessaryOkComment"
211-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]packageinfo[\\/]test1[\\/]package-info.java"/>
212-
<suppress id="UnnecessaryOkComment"
213-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]packageinfo[\\/]test2[\\/]package-info.java"/>
214104
<suppress id="UnnecessaryOkComment"
215105
files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadCheckEmoji.java"/>
216106
<suppress id="UnnecessaryOkComment"
@@ -329,8 +219,4 @@
329219
files="checks[\\/]javadoc[\\/]javadoctype[\\/]InputJavadocType1.java"/>
330220
<suppress id="UnnecessaryOkComment"
331221
files="checks[\\/]javadoc[\\/]javadoctype[\\/]InputJavadocType3.java"/>
332-
<suppress id="UnnecessaryOkComment"
333-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparator.java"/>
334-
<suppress id="UnnecessaryOkComment"
335-
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]InputEmptyLineSeparator2.java"/>
336222
</suppressions>

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparator.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ class SecondInnerClass {
130130
}
131131

132132
class Class2{
133-
public int compareTo(InputEmptyLineSeparator aObject) //ok
133+
public int compareTo(InputEmptyLineSeparator aObject)
134134
{
135135
int number = 0;
136136
return 0;
137137
}
138138

139139
Class2 anon = new Class2(){
140-
public int compareTo(InputEmptyLineSeparator aObject) //ok
140+
public int compareTo(InputEmptyLineSeparator aObject)
141141
{
142142
int number = 0;
143143
return 0;

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparator2.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ class SecondInnerClass {
130130
}
131131

132132
class Class22{
133-
public int compareTo(InputEmptyLineSeparator aObject) //ok
133+
public int compareTo(InputEmptyLineSeparator aObject)
134134
{
135135
int number = 0;
136136
return 0;
137137
}
138138

139139
Class2 anon = new Class2(){
140-
public int compareTo(InputEmptyLineSeparator aObject) //ok
140+
public int compareTo(InputEmptyLineSeparator aObject)
141141
{
142142
int number = 0;
143143
return 0;

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorBlockCommentSeparatedFromPackage.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
/* ok
1616
*/
1717

18-
public class InputEmptyLineSeparatorBlockCommentSeparatedFromPackage // ok
18+
public class InputEmptyLineSeparatorBlockCommentSeparatedFromPackage
1919
{
2020
}

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorEmptyLineAfterPackageForImportAst.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
99
*/
1010

11-
package com.puppycrawl.tools.checkstyle.checks.whitespace.emptylineseparator; // ok
11+
package com.puppycrawl.tools.checkstyle.checks.whitespace.emptylineseparator; // some comment
1212
/**
1313
* ok, no violation.
1414
*

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorEnumMembers.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ enum A {
2121

2222
private final String str; // violation ''VARIABLE_DEF' has more than 1 empty lines before.'
2323

24-
private String otherString; // ok
24+
private String otherString;
2525

2626

2727
private String thirdString; // violation ''VARIABLE_DEF' has more than 1 empty lines before.'

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorFormerException.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
1111
*/
1212

13-
package com.puppycrawl.tools.checkstyle.checks.whitespace.emptylineseparator; // ok
13+
package com.puppycrawl.tools.checkstyle.checks.whitespace.emptylineseparator; // some comment
1414

1515
public class InputEmptyLineSeparatorFormerException
1616
{

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorImportSeparatedFromPackage.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
import java.util.Calendar;
1717
import java.util.Date;
1818

19-
public class InputEmptyLineSeparatorImportSeparatedFromPackage // ok
19+
public class InputEmptyLineSeparatorImportSeparatedFromPackage
2020
{
2121
}

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorImports.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@
1515
import java.math.BigDecimal;
1616
import static java.lang.Math.abs;
1717

18-
public class InputEmptyLineSeparatorImports { // ok
18+
public class InputEmptyLineSeparatorImports {
1919
}

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/emptylineseparator/InputEmptyLineSeparatorInterfaceFields.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
package com.puppycrawl.tools.checkstyle.checks.whitespace.emptylineseparator;
1414

1515
public interface InputEmptyLineSeparatorInterfaceFields {
16-
int a = 45; // ok
16+
int a = 45;
1717

18-
int b = 45; // ok
18+
int b = 45;
1919

2020

2121
int c = 45; // violation ''VARIABLE_DEF' has more than 1 empty lines before.'
@@ -26,9 +26,9 @@ public interface InputEmptyLineSeparatorInterfaceFields {
2626
}
2727

2828
@interface Ann {
29-
int a = 45; // ok
29+
int a = 45;
3030

31-
int b = 45; // ok
31+
int b = 45;
3232

3333

3434
int c = 45; // violation ''VARIABLE_DEF' has more than 1 empty lines before.'

0 commit comments

Comments
 (0)