Issue #18926: Re-enable 'EqualsWithItself' inspection

vivek-0509 · romani · commit a9ccd9745e25 · 2026-02-26T05:38:46.000-08:00
diff --git a/config/intellij-idea-inspections.xml b/config/intellij-idea-inspections.xml
@@ -1767,9 +1767,8 @@
                    enabled_by_default="true"/>
   <inspection_tool class="EqualsWhichDoesntCheckParameterClass" enabled="true" level="ERROR"
                    enabled_by_default="true"/>
-  <!-- temporary disabled until https://github.com/checkstyle/checkstyle/issues/18926 -->
-  <inspection_tool class="EqualsWithItself" enabled="false" level="ERROR"
-                   enabled_by_default="false"/>
+  <inspection_tool class="EqualsWithItself" enabled="true" level="ERROR"
+                   enabled_by_default="true"/>
   <!-- there is false-positive, and rest cases are result of our loading modules by reflection
     that throws Error. Error is not always jvm problem,
     a bunch of libraries throw Error instead of Exception -->
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/LineColumnTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/LineColumnTest.java
@@ -30,7 +30,8 @@ public class LineColumnTest {
 
     @Test
     public void testCompareToBothEqual() {
-        final int actual = new LineColumn(0, 0).compareTo(new LineColumn(0, 0));
+        final LineColumn lineColumn = new LineColumn(0, 0);
+        final int actual = lineColumn.compareTo(new LineColumn(0, 0));
         assertWithMessage("Invalid LineColumn comparing result")
                 .that(actual)
                 .isEqualTo(0);
