Skip to content

Commit 8135d34

Browse files
AsthaDhapodkarromani
AsthaDhapodkar
authored and
romani
committed
Issue #11163: Split InputHiddenField2 into focused test inputs
1 parent 9259fc6 commit 8135d34

10 files changed

Lines changed: 461 additions & 370 deletions

File tree

‎config/checkstyle-resources-suppressions.xml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,6 @@
398398
files="[\\/]test[\\/]resources[\\/]com[\\/]puppycrawl[\\/]tools[\\/]checkstyle[\\/]checks[\\/]coding[\\/]hiddenfield[\\/]InputHiddenField7\.java"/>
399399
<suppress checks="FileLength"
400400
files="[\\/]test[\\/]resources[\\/]com[\\/]puppycrawl[\\/]tools[\\/]checkstyle[\\/]checks[\\/]coding[\\/]hiddenfield[\\/]InputHiddenFieldLambdas\.java"/>
401-
<suppress checks="FileLength"
402-
files="[\\/]test[\\/]resources[\\/]com[\\/]puppycrawl[\\/]tools[\\/]checkstyle[\\/]checks[\\/]coding[\\/]hiddenfield[\\/]InputHiddenField2\.java"/>
403401
<suppress checks="FileLength"
404402
files="[\\/]test[\\/]resources[\\/]com[\\/]puppycrawl[\\/]tools[\\/]checkstyle[\\/]checks[\\/]coding[\\/]hiddenfield[\\/]InputHiddenField8\.java"/>
405403
<suppress checks="FileLength"

‎src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheckTest.java‎

Lines changed: 76 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -149,47 +149,86 @@ public void testHiddenFieldMisc() throws Exception {
149149
}
150150

151151
@Test
152-
public void testDefault()
153-
throws Exception {
152+
public void testHiddenField2Basic() throws Exception {
154153
final String[] expected = {
155-
"30:13: " + getCheckMessage(MSG_KEY, "hidden"),
156-
"33:34: " + getCheckMessage(MSG_KEY, "hidden"),
157-
"40:13: " + getCheckMessage(MSG_KEY, "hidden"),
158-
"45:18: " + getCheckMessage(MSG_KEY, "hidden"),
159-
"50:33: " + getCheckMessage(MSG_KEY, "hidden"),
154+
"21:13: " + getCheckMessage(MSG_KEY, "hidden"),
155+
"24:39: " + getCheckMessage(MSG_KEY, "hidden"),
156+
"31:13: " + getCheckMessage(MSG_KEY, "hidden"),
157+
"36:18: " + getCheckMessage(MSG_KEY, "hidden"),
158+
"41:33: " + getCheckMessage(MSG_KEY, "hidden"),
159+
"52:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
160+
"55:26: " + getCheckMessage(MSG_KEY, "innerHidden"),
160161
"61:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
161-
"64:26: " + getCheckMessage(MSG_KEY, "innerHidden"),
162-
"70:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
163-
"71:17: " + getCheckMessage(MSG_KEY, "hidden"),
164-
"76:22: " + getCheckMessage(MSG_KEY, "innerHidden"),
165-
"80:22: " + getCheckMessage(MSG_KEY, "hidden"),
166-
"85:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
167-
"87:17: " + getCheckMessage(MSG_KEY, "hidden"),
168-
"93:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
169-
"94:17: " + getCheckMessage(MSG_KEY, "hidden"),
170-
"99:13: " + getCheckMessage(MSG_KEY, "hidden"),
171-
"117:29: " + getCheckMessage(MSG_KEY, "prop"),
172-
"123:29: " + getCheckMessage(MSG_KEY, "prop"),
173-
"129:29: " + getCheckMessage(MSG_KEY, "prop"),
174-
"141:28: " + getCheckMessage(MSG_KEY, "prop"),
175-
"155:13: " + getCheckMessage(MSG_KEY, "hidden"),
176-
"160:13: " + getCheckMessage(MSG_KEY, "hidden"),
177-
"165:13: " + getCheckMessage(MSG_KEY, "hidden"),
178-
"169:13: " + getCheckMessage(MSG_KEY, "hidden"),
179-
"196:23: " + getCheckMessage(MSG_KEY, "y"),
180-
"217:17: " + getCheckMessage(MSG_KEY, "hidden"),
181-
"227:22: " + getCheckMessage(MSG_KEY, "hidden"),
182-
"234:13: " + getCheckMessage(MSG_KEY, "hidden"),
183-
"240:13: " + getCheckMessage(MSG_KEY, "hiddenStatic"),
184-
"247:41: " + getCheckMessage(MSG_KEY, "x"),
185-
"253:30: " + getCheckMessage(MSG_KEY, "xAxis"),
186-
"270:41: " + getCheckMessage(MSG_KEY, "prop"),
187-
"284:29: " + getCheckMessage(MSG_KEY, "prop"),
188-
"295:42: " + getCheckMessage(MSG_KEY, "prop2"),
189-
"307:19: " + getCheckMessage(MSG_KEY, "i"),
162+
"62:17: " + getCheckMessage(MSG_KEY, "hidden"),
163+
"67:22: " + getCheckMessage(MSG_KEY, "innerHidden"),
164+
"71:22: " + getCheckMessage(MSG_KEY, "hidden"),
165+
"76:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
166+
"78:17: " + getCheckMessage(MSG_KEY, "hidden"),
167+
"84:17: " + getCheckMessage(MSG_KEY, "innerHidden"),
168+
"85:17: " + getCheckMessage(MSG_KEY, "hidden"),
169+
"90:13: " + getCheckMessage(MSG_KEY, "hidden"),
170+
};
171+
verifyWithInlineConfigParser(
172+
getPath("InputHiddenField2Basic.java"), expected);
173+
}
174+
175+
@Test
176+
public void testHiddenField2Interface() throws Exception {
177+
final String[] expected = {
178+
};
179+
verifyWithInlineConfigParser(
180+
getPath("InputHiddenField2Interface.java"), expected);
181+
}
182+
183+
@Test
184+
public void testHiddenField2Static() throws Exception {
185+
final String[] expected = {
186+
"22:13: " + getCheckMessage(MSG_KEY, "hidden"),
187+
"27:13: " + getCheckMessage(MSG_KEY, "hidden"),
188+
"32:13: " + getCheckMessage(MSG_KEY, "hidden"),
189+
"36:13: " + getCheckMessage(MSG_KEY, "hidden"),
190+
"63:23: " + getCheckMessage(MSG_KEY, "y"),
191+
};
192+
verifyWithInlineConfigParser(
193+
getPath("InputHiddenField2Static.java"), expected);
194+
}
195+
196+
@Test
197+
public void testHiddenField2PropertySetter() throws Exception {
198+
final String[] expected = {
199+
"21:29: " + getCheckMessage(MSG_KEY, "prop"),
200+
"27:29: " + getCheckMessage(MSG_KEY, "prop"),
201+
"33:29: " + getCheckMessage(MSG_KEY, "prop"),
202+
"45:28: " + getCheckMessage(MSG_KEY, "prop"),
203+
"64:41: " + getCheckMessage(MSG_KEY, "prop"),
204+
"78:29: " + getCheckMessage(MSG_KEY, "prop"),
205+
"89:42: " + getCheckMessage(MSG_KEY, "prop2"),
206+
};
207+
verifyWithInlineConfigParser(
208+
getPath("InputHiddenField2PropertySetter.java"), expected);
209+
}
210+
211+
@Test
212+
public void testHiddenField2Enum() throws Exception {
213+
final String[] expected = {
214+
"30:17: " + getCheckMessage(MSG_KEY, "hidden"),
215+
"40:31: " + getCheckMessage(MSG_KEY, "hidden"),
216+
"47:13: " + getCheckMessage(MSG_KEY, "hidden"),
217+
"53:13: " + getCheckMessage(MSG_KEY, "hiddenStatic"),
218+
};
219+
verifyWithInlineConfigParser(
220+
getPath("InputHiddenField2Enum.java"), expected);
221+
}
222+
223+
@Test
224+
public void testHiddenField2Misc() throws Exception {
225+
final String[] expected = {
226+
"19:45: " + getCheckMessage(MSG_KEY, "x"),
227+
"24:34: " + getCheckMessage(MSG_KEY, "xAxis"),
228+
"31:23: " + getCheckMessage(MSG_KEY, "i"),
190229
};
191230
verifyWithInlineConfigParser(
192-
getPath("InputHiddenField2.java"), expected);
231+
getPath("InputHiddenField2Misc.java"), expected);
193232
}
194233

195234
/** Tests ignoreFormat property. */

0 commit comments

Comments
 (0)