Skip to content

Commit c94b1f4

Browse files
karthiknadigbrettcannonKim-Adeline Miguel
authored
Remove old code (#16877)
* Remove ctags (#16066) * Remove rope (#16064) * Remove default pylint when using jedi (#16074) * Remove default pylint when using jedi * Remove pylint minimal checkers * Remove more pylint config * Restore missed configuration file names * More linting clean up * Fix tests * Remove unused files and update branch (#16128) * Add the 'security-events' permission to the CodeQL workflow (#16071) * Delete misc files we don't need anymore Co-authored-by: Brett Cannon <brett@python.org> * Rebase with main * Update news items. * Remove unused telemetry * Test build workflow * Remove ropeproject from repo settings * Remove workspace symbols * Update .eslintignore * Remove testing of build workflow * Remove unused symbolProvider.py Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Kim-Adeline Miguel <kimiguel@microsoft.com>
1 parent e8b109c commit c94b1f4

114 files changed

Lines changed: 535 additions & 4768 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.eslintignore‎

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -191,14 +191,6 @@ src/test/application/misc/joinMailingListPrompt.unit.test.ts
191191

192192
src/test/performance/load.perf.test.ts
193193

194-
src/test/refactor/extension.refactor.extract.method.test.ts
195-
src/test/refactor/extension.refactor.extract.var.test.ts
196-
197-
src/test/workspaceSymbols/provider.unit.test.ts
198-
src/test/workspaceSymbols/common.ts
199-
src/test/workspaceSymbols/main.unit.test.ts
200-
src/test/workspaceSymbols/generator.unit.test.ts
201-
202194
src/client/interpreter/configuration/interpreterSelector/commands/base.ts
203195
src/client/interpreter/configuration/interpreterSelector/commands/resetInterpreter.ts
204196
src/client/interpreter/configuration/interpreterSelector/commands/setShebangInterpreter.ts
@@ -223,27 +215,16 @@ src/client/terminals/codeExecution/terminalCodeExecution.ts
223215
src/client/terminals/codeExecution/codeExecutionManager.ts
224216
src/client/terminals/codeExecution/djangoContext.ts
225217

226-
src/client/providers/objectDefinitionProvider.ts
227218
src/client/providers/serviceRegistry.ts
228-
src/client/providers/symbolProvider.ts
229219
src/client/providers/completionSource.ts
230-
src/client/providers/renameProvider.ts
231-
src/client/providers/hoverProvider.ts
232-
src/client/providers/itemInfoSource.ts
233220
src/client/providers/formatProvider.ts
234221
src/client/providers/importSortProvider.ts
235222
src/client/providers/replProvider.ts
236223
src/client/providers/codeActionProvider/main.ts
237224
src/client/providers/codeActionProvider/launchJsonCodeActionProvider.ts
238225
src/client/providers/codeActionProvider/pythonCodeActionProvider.ts
239-
src/client/providers/docStringFoldingProvider.ts
240226
src/client/providers/linterProvider.ts
241-
src/client/providers/simpleRefactorProvider.ts
242-
src/client/providers/completionProvider.ts
243-
src/client/providers/definitionProvider.ts
244-
src/client/providers/referenceProvider.ts
245227
src/client/providers/terminalProvider.ts
246-
src/client/providers/signatureProvider.ts
247228

248229
src/client/activation/languageServer/manager.ts
249230
src/client/activation/languageServer/languageServerExtension.ts
@@ -464,9 +445,3 @@ src/client/application/diagnostics/commands/factory.ts
464445
src/client/application/diagnostics/commands/execVSCCommand.ts
465446
src/client/application/diagnostics/commands/launchBrowser.ts
466447

467-
src/client/refactor/proxy.ts
468-
src/client/workspaceSymbols/main.ts
469-
src/client/workspaceSymbols/generator.ts
470-
src/client/workspaceSymbols/parser.ts
471-
src/client/workspaceSymbols/provider.ts
472-

‎.github/test_plan.md‎

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -141,36 +141,15 @@ SPAM='hello ${WHO}'
141141
- [ ] Create a virtual environment
142142
- [ ] Install `requests` into the virtual environment
143143

144-
#### Pylint/default linting
145-
146-
[Prompting to install Pylint is covered under `Environments` above]
147-
148-
For testing the disablement of the default linting rules for Pylint:
149-
150-
```ini
151-
# pylintrc
152-
[MESSAGES CONTROL]
153-
enable=bad-names
154-
```
155-
156-
```python3
157-
# example.py
158-
foo = 42 # Marked as a disallowed name.
159-
```
160-
161-
- [ ] Installation via the prompt installs Pylint as appropriate
162-
- [ ] Uses `--user` for system-install of Python
163-
- [ ] Installs into a virtual environment environment directly
164-
- [ ] Pylint works
165-
- [ ] The existence of a `pylintrc` file turns off the default rules
166-
167-
#### Other linters
144+
#### Linting
168145

169146
**Note**:
170147

171148
- You can use the `Run Linting` command to run a newly installed linter
172149
- When the extension installs a new linter, it turns off all other linters
173150

151+
- [ ] pylint works
152+
- [ ] `Select linter` lists the linter and installs it if necessary
174153
- [ ] flake8 works
175154
- [ ] `Select linter` lists the linter and installs it if necessary
176155
- [ ] mypy works
@@ -223,14 +202,6 @@ def foo():pass
223202
- [ ] yapf
224203
- [ ] `"editor.formatOnType": true` works and has expected results
225204

226-
#### [Refactoring](https://code.visualstudio.com/docs/python/editing#_refactoring)
227-
228-
- [ ] [`Extract Variable`](https://code.visualstudio.com/docs/python/editing#_extract-variable) works
229-
- [ ] You are prompted to install `rope` if it is not already available
230-
- [ ] [`Extract method`](https://code.visualstudio.com/docs/python/editing#_extract-method) works
231-
- [ ] You are prompted to install `rope` if it is not already available
232-
- [ ] [`Sort Imports`](https://code.visualstudio.com/docs/python/editing#_sort-imports) works
233-
234205
### [Debugging](https://code.visualstudio.com/docs/python/debugging)
235206

236207
- [ ] [Configurations](https://code.visualstudio.com/docs/python/debugging#_debugging-specific-app-types) work (see [`package.json`](https://github.com/Microsoft/vscode-python/blob/main/package.json) and the `"configurationSnippets"` section for all of the possible configurations)

‎.vscode/settings.json‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
".vscode-test": false,
1313
".vscode test": false,
1414
"**/.mypy_cache/**": true,
15-
"**/.ropeproject/**": true
1615
},
1716
"search.exclude": {
1817
"out": true, // set this to false to include "out" folder in search results
@@ -45,7 +44,6 @@
4544
"typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version
4645
"python.linting.enabled": false,
4746
"python.testing.promptToConfigure": false,
48-
"python.workspaceSymbols.enabled": false,
4947
"python.formatting.provider": "black",
5048
"typescript.preferences.quoteStyle": "single",
5149
"javascript.preferences.quoteStyle": "single",

‎build/conda-functional-requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ pycodestyle
1111
pydocstyle
1212
nose
1313
pytest==4.6.9 # Last version of pytest with Python 2.7 support
14-
rope
1514
fastapi ; python_version>='3.6'
1615
uvicorn ; python_version>='3.6'
1716
flask

‎build/test-requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ pycodestyle
1010
pydocstyle
1111
prospector ; python_version > '2.7'
1212
pytest<6 ; python_version > '2.7' # Tests currently fail against pytest 6.
13-
rope
1413
flask
1514
fastapi ; python_version > '2.7'
1615
uvicorn ; python_version > '2.7'

‎news/3 Code Health/10440.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove support for `rope`. Refactoring now supported via language servers.

‎news/3 Code Health/13321.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove `pylintMinimalCheckers` setting. Syntax errors now reported via language servers.

‎news/3 Code Health/16063.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove `ctags` support. Workspace symbols now supported via language servers.

‎package.json‎

Lines changed: 0 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
"onCommand:python.viewOutput",
6868
"onCommand:python.execSelectionInTerminal",
6969
"onCommand:python.execSelectionInDjangoShell",
70-
"onCommand:python.buildWorkspaceSymbols",
7170
"onCommand:python.startREPL",
7271
"onCommand:python.goToPythonObject",
7372
"onCommand:python.reportIssue",
@@ -308,11 +307,6 @@
308307
"command": "python.analysis.restartLanguageServer",
309308
"title": "%python.command.python.analysis.restartLanguageServer.title%"
310309
},
311-
{
312-
"category": "Python",
313-
"command": "python.buildWorkspaceSymbols",
314-
"title": "%python.command.python.buildWorkspaceSymbols.title%"
315-
},
316310
{
317311
"category": "Python",
318312
"command": "python.clearPersistentStorage",
@@ -380,16 +374,6 @@
380374
"command": "python.launchTensorBoard",
381375
"title": "%python.command.python.launchTensorBoard.title%"
382376
},
383-
{
384-
"category": "Python Refactor",
385-
"command": "python.refactorExtractMethod",
386-
"title": "%python.command.python.refactorExtractMethod.title%"
387-
},
388-
{
389-
"category": "Python Refactor",
390-
"command": "python.refactorExtractVariable",
391-
"title": "%python.command.python.refactorExtractVariable.title%"
392-
},
393377
{
394378
"category": "Python",
395379
"command": "python.refreshTensorBoard",
@@ -1275,47 +1259,6 @@
12751259
"description": "Path to folder with a list of Virtual Environments (e.g. ~/.pyenv, ~/Envs, ~/.virtualenvs).",
12761260
"scope": "machine",
12771261
"type": "string"
1278-
},
1279-
"python.workspaceSymbols.ctagsPath": {
1280-
"default": "ctags",
1281-
"description": "Fully qualified path to the ctags executable (else leave as ctags, assuming it is in current path).",
1282-
"scope": "resource",
1283-
"type": "string"
1284-
},
1285-
"python.workspaceSymbols.enabled": {
1286-
"default": false,
1287-
"description": "Set to 'true' to enable ctags to provide Workspace Symbols.",
1288-
"scope": "resource",
1289-
"type": "boolean"
1290-
},
1291-
"python.workspaceSymbols.exclusionPatterns": {
1292-
"default": [
1293-
"**/site-packages/**"
1294-
],
1295-
"description": "Pattern used to exclude files and folders from ctags See http://ctags.sourceforge.net/ctags.html.",
1296-
"items": {
1297-
"type": "string"
1298-
},
1299-
"scope": "resource",
1300-
"type": "array"
1301-
},
1302-
"python.workspaceSymbols.rebuildOnFileSave": {
1303-
"default": true,
1304-
"description": "Whether to re-build the tags file on when changes made to python files are saved.",
1305-
"scope": "resource",
1306-
"type": "boolean"
1307-
},
1308-
"python.workspaceSymbols.rebuildOnStart": {
1309-
"default": true,
1310-
"description": "Whether to re-build the tags file on start (defaults to true).",
1311-
"scope": "resource",
1312-
"type": "boolean"
1313-
},
1314-
"python.workspaceSymbols.tagFilePath": {
1315-
"default": "${workspaceFolder}/.vscode/tags",
1316-
"description": "Fully qualified path to tag file (exuberant ctag file), used to provide workspace symbols.",
1317-
"scope": "resource",
1318-
"type": "string"
13191262
}
13201263
},
13211264
"title": "Python",
@@ -1826,18 +1769,6 @@
18261769
"group": "Python",
18271770
"when": "editorFocus && editorLangId == python"
18281771
},
1829-
{
1830-
"command": "python.refactorExtractMethod",
1831-
"group": "Refactor",
1832-
"title": "Refactor: Extract Method",
1833-
"when": "editorHasSelection && editorLangId == python && !notebookEditorFocused"
1834-
},
1835-
{
1836-
"command": "python.refactorExtractVariable",
1837-
"group": "Refactor",
1838-
"title": "Refactor: Extract Variable",
1839-
"when": "editorHasSelection && editorLangId == python && !notebookEditorFocused"
1840-
},
18411772
{
18421773
"command": "python.sortImports",
18431774
"group": "Refactor",

‎package.nls.de.json‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,8 @@
22
"python.command.python.sortImports.title": "Sortieren der Importe",
33
"python.command.python.startREPL.title": "Starten des REPL",
44
"python.command.python.createTerminal.title": "Terminal erstellen",
5-
"python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole erstellen",
65
"python.command.python.execInTerminal.title": "Python-Datei im Terminal ausführen",
76
"python.command.python.setInterpreter.title": "Interpreter auswählen",
8-
"python.command.python.refactorExtractVariable.title": "Variable extrahieren",
9-
"python.command.python.refactorExtractMethod.title": "Methode extrahieren",
107
"python.command.python.execSelectionInTerminal.title": "Selektion/Reihe in Python-Terminal ausführen",
118
"python.command.python.execSelectionInDjangoShell.title": "Selektion/Reihe in Django-Shell ausführen",
129
"python.command.python.goToPythonObject.title": "Gehe zu Python-Objekt",

0 commit comments

Comments
 (0)