Ignore errors when accessing shell info using VSC API (#6641)

DonJayamanne · web-flow · commit 13ea009d70c5 · 2019-07-19T12:58:30.000-07:00
* Ignore errors
* Use simple try catch
* Ooops
diff --git a/src/client/common/application/applicationEnvironment.ts b/src/client/common/application/applicationEnvironment.ts
@@ -7,6 +7,7 @@ import { inject, injectable } from 'inversify';
 import * as path from 'path';
 import { parse } from 'semver';
 import * as vscode from 'vscode';
+import { traceError } from '../logger';
 import { IPlatformService } from '../platform/types';
 import { ICurrentProcess, IPathUtils } from '../types';
 import { OSType } from '../utils/platform';
@@ -50,9 +51,22 @@ export class ApplicationEnvironment implements IApplicationEnvironment {
         // tslint:disable-next-line:non-literal-require
         return this.packageJson.displayName;
     }
+    /**
+     * At the time of writing this API, the vscode.env.shell isn't officially released in stable version of VS Code.
+     * Using this in stable version seems to throw errors in VSC with messages being displayed to the user about use of
+     * unstable API.
+     * Solution - log and suppress the errors.
+     * @readonly
+     * @type {(string | undefined)}
+     * @memberof ApplicationEnvironment
+     */
     public get shell(): string | undefined {
-        // tslint:disable-next-line:no-any
-        return (vscode.env as any).shell;
+        try {
+            // tslint:disable-next-line:no-any
+            return (vscode.env as any).shell;
+        } catch (error) {
+            traceError('Unable to determine shell using VS Code API.', error);
+        }
     }
     // tslint:disable-next-line:no-any
     public get packageJson(): any {
