Upgrade to Node 14 (#18149)

kimadeline · web-flow · commit 0eddfbf9e468 · 2021-12-13T08:26:09.000-08:00
* Update .nvmrc and @types/node

* Update package-lock.json

* Fix the only compilation error

* Use Node 14 in GH workflows

* News file
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -9,7 +9,7 @@ on:
       - 'release-*'
 
 env:
-  NODE_VERSION: 12.15.0
+  NODE_VERSION: 14.18.2
   # Force a path with spaces and to test extension works in these scenarios
   # Unicode characters are causing 2.7 failures so skip that for now.
   special-working-directory: './path with spaces'
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -8,7 +8,7 @@ on:
       - release*
 
 env:
-  NODE_VERSION: 12.15.0
+  NODE_VERSION: 14.18.2
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
   ARTIFACT_NAME_VSIX: ms-python-insiders-vsix
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v12.20.0
+v14.18.2
diff --git a/news/3 Code Health/18148.md b/news/3 Code Health/18148.md
@@ -0,0 +1 @@
+Upgrade to Node 14 LTS (v14.18.2).
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1954,7 +1954,7 @@
         "@types/md5": "^2.1.32",
         "@types/mocha": "^5.2.7",
         "@types/nock": "^10.0.3",
-        "@types/node": "^12.19.12",
+        "@types/node": "^14.18.0",
         "@types/request": "^2.47.0",
         "@types/semver": "^5.5.0",
         "@types/shortid": "^0.0.29",
diff --git a/src/client/common/platform/fileSystem.ts b/src/client/common/platform/fileSystem.ts
@@ -122,7 +122,7 @@ export class RawFileSystem implements IRawFileSystem {
             // The "fs-extra" module is effectively equivalent to node's "fs"
             // module (but is a bit more async-friendly).  So we use that
             // instead of "fs".
-            fsExtra || fs,
+            fsExtra || (fs as IRawFSExtra),
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ export class RawFileSystem implements IRawFileSystem {`
`122`	`122`	`// The "fs-extra" module is effectively equivalent to node's "fs"`
`123`	`123`	`// module (but is a bit more async-friendly). So we use that`
`124`	`124`	`// instead of "fs".`
`125`		`- fsExtra \|\| fs,`
	`125`	`+ fsExtra \|\| (fs as IRawFSExtra),`
`126`	`126`	`);`
`127`	`127`	`}`
`128`	`128`