Skip to content

Minor version of peer package causes release of major version #524

Description

@danielkcz

Affected Packages

Here is the specific commit generated by changeset-release action.

mobxjs/mobx@c1f3019

Problem

As you can see, there is a single changeset with minor change to the two packages, mobx and mobx-react-lite. What's unexpected here is the major release of mobx-react-lite and mobx-react in cascade. Even in the changelog, it talks about minor/patch changes so it's rather confusing to the end user.

The mobx-react-lite depends on mobx, but only as peerDependency. In my opinion, it doesn't make much sense to force major in such a case. Minor versions are about adding something new, it's not breaking. What is the reasoning here?

Proposed solution

I think it should release a minor version of mobx-react-lite as requested.

We have fixed it manually for now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions