msgpack#188: Fix MessageBuffer.wrap(ByteBuffer) to consider position() and remaining()

xerial · xerial · commit a56e3a28627e · 2015-02-02T10:26:51.000+09:00
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MessagePacker.java b/msgpack-core/src/main/java/org/msgpack/core/MessagePacker.java
@@ -506,7 +506,7 @@ public MessagePacker writePayload(ByteBuffer src) throws IOException {
             flush();
 
             // Wrap the input source as a MessageBuffer
-            MessageBuffer wrapped = MessageBuffer.wrap(src).slice(src.position(), src.remaining());
+            MessageBuffer wrapped = MessageBuffer.wrap(src);
             // Then, dump the source data to the output
             out.flush(wrapped);
             src.position(src.limit());
diff --git a/msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBuffer.java b/msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBuffer.java
@@ -256,7 +256,7 @@ public static MessageBuffer wrap(byte[] array) {
     }
 
     public static MessageBuffer wrap(ByteBuffer bb) {
-        return newMessageBuffer(bb);
+        return newMessageBuffer(bb).slice(bb.position(), bb.remaining());
     }
 
     /**
diff --git a/msgpack-core/src/test/scala/org/msgpack/core/buffer/MessageBufferTest.scala b/msgpack-core/src/test/scala/org/msgpack/core/buffer/MessageBufferTest.scala
@@ -11,6 +11,14 @@ class MessageBufferTest extends MessagePackSpec {
 
   "MessageBuffer" should {
 
+    "wrap ByteBuffer considering position and remaining values" taggedAs("wrap-bb") in {
+      val d = Array[Byte](10,11,12,13,14,15,16,17,18,19)
+      val subset = ByteBuffer.wrap(d, 2, 2)
+      val mb = MessageBuffer.wrap(subset)
+      mb.getByte(0) shouldBe 12
+      mb.size() shouldBe 2
+    }
+
     "have better performance than ByteBuffer" in {
 
       val N = 1000000

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ public static MessageBuffer wrap(byte[] array) {`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`public static MessageBuffer wrap(ByteBuffer bb) {`
`259`		`- return newMessageBuffer(bb);`
	`259`	`+ return newMessageBuffer(bb).slice(bb.position(), bb.remaining());`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`/**`